Page MenuHomeFreeBSD

Fix epoch's use of turnstile_lock().
ClosedPublic

Authored by markj on Jul 24 2019, 1:39 AM.
Tags
None
Referenced Files
F148373323: D21048.id60114.diff
Tue, Mar 17, 10:49 AM
Unknown Object (File)
Sun, Mar 15, 2:00 PM
Unknown Object (File)
Fri, Mar 13, 10:45 AM
Unknown Object (File)
Thu, Mar 12, 2:14 PM
Unknown Object (File)
Wed, Mar 4, 10:18 AM
Unknown Object (File)
Tue, Mar 3, 12:02 AM
Unknown Object (File)
Mon, Mar 2, 2:34 AM
Unknown Object (File)
Feb 7 2026, 11:02 PM
Subscribers

Details

Summary

turnstile_lock() was added specifically for use in epoch. While waiting
for readers to drain, if the blocking thread discovers a reader blocked
on a turnstile, it will also block on the turnstile. It previously
returned the value of the ts_owner field to indicate that the turnstile
was successfully locked, and NULL to indicate that the race was lost.
But, ts_owner may be NULL if the turnstile corresponds to a rw lock
owned by one or more readers, in which case the epoch code leaked the
turnstile lock and chain lock.

Apply a minimal fix: simply return the owner as a separate value.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25478
Build 24097: arc lint + arc unit