Page MenuHomeFreeBSD

Enable witness blessings.
ClosedPublic

Authored by markj on Jul 23 2019, 5:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 5 2024, 3:44 PM
Unknown Object (File)
Sep 24 2024, 6:34 AM
Unknown Object (File)
Sep 21 2024, 4:54 AM
Unknown Object (File)
Sep 19 2024, 9:22 AM
Unknown Object (File)
Sep 18 2024, 7:16 PM
Unknown Object (File)
Sep 18 2024, 7:03 PM
Unknown Object (File)
Sep 18 2024, 8:56 AM
Unknown Object (File)
Sep 8 2024, 5:36 PM
Subscribers

Details

Summary

We have a number of false-positive LORs that get logged regularly on
WITNESS kernels. These warnings alarm new users and confuse test
automation which looks for genuine LORs. For instance, we regularly get
PRs reporting benign LORs.

WITNESS cannot track the complex locking relationships that make these
LORs harmless. There have been some proposals in the past for a
finer-grained mechanism to ignore these false positives, e.g., by adding
NOWITNESS flags to the various lock functions, or by specifying one or
more blessed lock pairs at a given lock site. These proposals all have
shortcomings, however, and worse, they were not implemented. We do
however have the ability to ignore LORs referring to specific lock pairs.
In the absence of a better solution, start using it to silence a couple
of commonly reported LORs.

I unconditionally enabled the blessing code; I didn't see a good reason
to make it conditional. I have no issue making it so if anyone can
suggest a reason.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25470
Build 24089: arc lint + arc unit

Event Timeline

markj added reviewers: kib, jhb, mckusick, jeff, cem.
This revision is now accepted and ready to land.Jul 23 2019, 8:14 PM

This is long overdue. I would love to have these known LORs ignored.

This revision was automatically updated to reflect the committed changes.