Page MenuHomeFreeBSD
Differential D13028

vnic: correct and simplify SIOCSIFFLAGS ioctl
ClosedPublic
Actions

Authored by emaste on Nov 10 2017, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 1:20 PM
Unknown Object (File)
Nov 24 2025, 3:37 AM
Unknown Object (File)
Nov 20 2025, 6:46 PM
Unknown Object (File)
Nov 20 2025, 6:46 PM
Unknown Object (File)
Nov 20 2025, 6:45 PM
Unknown Object (File)
Nov 20 2025, 6:45 PM
Unknown Object (File)
Nov 20 2025, 6:44 PM
Unknown Object (File)
Nov 20 2025, 6:30 PM
View All Files
Subscribers
imp

Details

Reviewers
bz
andrew
Commits
rS351664: vnic: correct and simplify SIOCSIFFLAGS
Summary

flags variable was unused, and the IFF_PROMISC logic was broken. Rework and simplify.

Should be a nop because promisc & allmulti don't do anything yet anyhow.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Nov 10 2017, 2:36 PM
emaste updated this revision to Diff 35036.Nov 10 2017, 2:40 PM

undo accidental if_getdrvflags breakage

emaste updated this revision to Diff 59390.Jul 4 2019, 12:58 PM

rebase

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 4:53 PM
Closed by commit rS351664: vnic: correct and simplify SIOCSIFFLAGS (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS351664: vnic: correct and simplify SIOCSIFFLAGS.
Herald added a subscriber: imp. · View Herald TranscriptSep 1 2019, 4:53 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vnic/
12 lines

Diff 59390

View Options

sys/dev/vnic/nicvf_main.c

Loading...