Page MenuHomeFreeBSD
Differential D13028

vnic: correct and simplify SIOCSIFFLAGS ioctl
ClosedPublic
Actions

Authored by emaste on Nov 10 2017, 2:36 PM.
Tags
None
Referenced Files
F171333944: D13028.id61530.diff
Thu, Sep 10, 12:09 PM
Unknown Object (File)
Tue, Sep 8, 11:42 AM
Unknown Object (File)
Sun, Sep 6, 12:50 AM
Unknown Object (File)
Sat, Sep 5, 12:26 PM
Unknown Object (File)
Sat, Sep 5, 3:24 AM
Unknown Object (File)
Sat, Sep 5, 3:13 AM
Unknown Object (File)
Fri, Sep 4, 8:32 PM
Unknown Object (File)
Fri, Sep 4, 3:08 PM
View All Files
Subscribers
imp

Details

Reviewers
bz
andrew
Commits
rS351664: vnic: correct and simplify SIOCSIFFLAGS
Summary

flags variable was unused, and the IFF_PROMISC logic was broken. Rework and simplify.

Should be a nop because promisc & allmulti don't do anything yet anyhow.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Nov 10 2017, 2:36 PM
emaste updated this revision to Diff 35036.Nov 10 2017, 2:40 PM

undo accidental if_getdrvflags breakage

emaste updated this revision to Diff 59390.Jul 4 2019, 12:58 PM

rebase

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 4:53 PM
Closed by commit rS351664: vnic: correct and simplify SIOCSIFFLAGS (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS351664: vnic: correct and simplify SIOCSIFFLAGS.
Herald added a subscriber: imp. · View Herald TranscriptSep 1 2019, 4:53 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vnic/
12 lines

Diff 35036

View Options

sys/dev/vnic/nicvf_main.c

Loading...