vnic: correct and simplify SIOCSIFFLAGS ioctl
ClosedPublic
Actions

Authored by emaste on Nov 10 2017, 2:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 1:23 PM

	Unknown Object (File)
	Tue, Apr 16, 5:36 AM

	Unknown Object (File)
	Tue, Apr 16, 5:31 AM

	Unknown Object (File)
	Tue, Apr 16, 4:59 AM

	Unknown Object (File)
	Tue, Apr 16, 4:48 AM

	Unknown Object (File)
	Tue, Apr 16, 4:48 AM

	Unknown Object (File)
	Feb 11 2024, 1:21 AM

	Unknown Object (File)
	Dec 20 2023, 1:58 AM

View All 41 Files

Subscribers

imp

Details

Reviewers

bz
andrew

Commits

rS351664: vnic: correct and simplify SIOCSIFFLAGS

Summary

flags variable was unused, and the IFF_PROMISC logic was broken. Rework and simplify.

Should be a nop because promisc & allmulti don't do anything yet anyhow.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Nov 10 2017, 2:36 PM

undo accidental if_getdrvflags breakage

rebase

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 4:53 PM

Closed by commit rS351664: vnic: correct and simplify SIOCSIFFLAGS (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS351664: vnic: correct and simplify SIOCSIFFLAGS.

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2019, 4:53 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

vnic/

nicvf_main.c

16 lines

Diff 35035

View Options

vnic: correct and simplify SIOCSIFFLAGS ioctlClosedPublicActions