Page MenuHomeFreeBSD
Differential D20847

fix style(9) violations involving division by PAGE_SIZE
ClosedPublic
Actions

Authored by dougm on Jul 3 2019, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 27, 3:40 AM
Unknown Object (File)
Thu, Nov 20, 4:16 PM
Unknown Object (File)
Thu, Nov 20, 3:06 PM
Unknown Object (File)
Thu, Nov 20, 3:05 PM
Unknown Object (File)
Thu, Nov 20, 3:05 PM
Unknown Object (File)
Thu, Nov 20, 2:55 PM
Unknown Object (File)
Mon, Nov 10, 2:21 AM
Unknown Object (File)
Mon, Nov 10, 2:19 AM
View All Files
Subscribers
cem
imp

Details

Reviewers
alc
kib
markj
Commits
rS349791: Fix style(9) violations involving division by PAGE_SIZE.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Jul 3 2019, 11:02 PM
dougm updated this revision to Diff 59381.Jul 4 2019, 2:25 AM
dougm retitled this revision from fix style(9) violations in swap_pager.c to fix style(9) violations involving division by PAGE_SIZE.

Include other files.

alc accepted this revision.Jul 6 2019, 3:41 PM
alc added reviewers: kib, markj.
This revision is now accepted and ready to land.Jul 6 2019, 3:41 PM
markj accepted this revision.Jul 6 2019, 3:41 PM
Closed by commit rS349791: Fix style(9) violations involving division by PAGE_SIZE. (authored by dougm). · Explain WhyJul 6 2019, 3:55 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS349791: Fix style(9) violations involving division by PAGE_SIZE..
Herald added a subscriber: imp. · View Herald TranscriptJul 6 2019, 3:55 PM
cem added a subscriber: cem.Jul 6 2019, 5:02 PM
cem added inline comments.
head/sys/vm/swap_pager.c
526 ↗(On Diff #59469)

The parentheses should not have been removed here.

alc added inline comments.Jul 6 2019, 5:24 PM
head/sys/vm/swap_pager.c
526 ↗(On Diff #59469)

Conrad, how about changing the wording here to, "... array, which has MAXPHYS / PAGE_SIZE entries, and ..."?

cem added inline comments.Jul 6 2019, 10:15 PM
head/sys/vm/swap_pager.c
526 ↗(On Diff #59469)

Alan, that sounds good to me, thanks!

Revision Contents
Changeset List

PathSize
sys/
vm/
4 lines
2 lines
4 lines

Diff 59381

View Options

sys/vm/swap_pager.c

Loading...
View Options

sys/vm/vm_pageout.c

Loading...
View Options

sys/vm/vnode_pager.c

Loading...