Differential D20744

g_mirror_taste: avoid deadlock, always clear tasting flag
ClosedPublic
Actions

Authored by rlibby on Jun 24 2019, 4:33 PM.

Details

Reviewers

markj
pjd

Commits

rS349587: g_mirror_taste: avoid deadlock, always clear tasting flag

Summary

If g_mirror_taste encountered an error at g_mirror_add_disk, it might
try to g_mirror_destroy the device with the G_MIRROR_DEVICE_FLAG_TASTING
flag still set. This would wait on a worker to complete the destruction
with g_mirror_try_destroy, but that function bails out if the tasting
flag is set, resulting in a deadlock. Clear the tasting flag before
trying to destroy the device.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Jun 24 2019, 4:33 PM

Harbormaster completed remote builds in B25007: Diff 58956.Jun 24 2019, 4:33 PM

As a precaution I'd suggest running the tests under /usr/tests/sys/geom/class/mirror.

This revision is now accepted and ready to land.Jun 24 2019, 6:16 PM

In D20744#448546, @markj wrote:

As a precaution I'd suggest running the tests under /usr/tests/sys/geom/class/mirror.

Yes, I believe that is what the kyua line above does (and that's how I found this). Or does that run only a subset of tests?

In D20744#448548, @rlibby wrote:

In D20744#448546, @markj wrote:

As a precaution I'd suggest running the tests under /usr/tests/sys/geom/class/mirror.

Yes, I believe that is what the kyua line above does (and that's how I found this). Or does that run only a subset of tests?