Page MenuHomeFreeBSD
Differential D20454

arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR
ClosedPublic
Actions

Authored by jchandra on May 29 2019, 3:40 AM.
Tags
None
Referenced Files
F116814649: D20454.diff
Sat, May 10, 1:36 PM
Unknown Object (File)
Thu, May 8, 11:52 PM
Unknown Object (File)
Fri, May 2, 2:43 AM
Unknown Object (File)
Thu, May 1, 4:08 PM
Unknown Object (File)
Mon, Apr 14, 9:43 AM
Unknown Object (File)
Mon, Apr 14, 5:02 AM
Unknown Object (File)
Mon, Apr 14, 12:55 AM
Unknown Object (File)
Mon, Apr 14, 12:46 AM
View All 87 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Commits
rS349345: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR
Summary

(split from earlier https://reviews.freebsd.org/D19842)
Now that GICV3_IVAR_REDIST is available, we can remove GICV3_IVAR_REDIST_VADDR

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jchandra created this revision.May 29 2019, 3:40 AM
Herald added a reviewer: manu. · View Herald TranscriptMay 29 2019, 3:40 AM
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B24578: Diff 58021.May 29 2019, 3:40 AM
andrew added inline comments.May 30 2019, 9:27 AM
sys/arm64/arm64/gic_v3_var.h
96 ↗(On Diff #58021)

I'd just remove it with a comment, e.g.:
/* 1001 was GICV3_IVAR_REDIST_VADDR */

jchandra added inline comments.May 30 2019, 6:00 PM
sys/arm64/arm64/gic_v3_var.h
96 ↗(On Diff #58021)

Will change.
(The #define looked better in my opinion, probably 'unused' was not the right description)

andrew added inline comments.May 30 2019, 8:50 PM
sys/arm64/arm64/gic_v3_var.h
96 ↗(On Diff #58021)

The main reason for removing the #define is to make it a compile error to continue using it.

jchandra updated this revision to Diff 58102.May 31 2019, 3:45 AM

address andrew's comment.

Harbormaster completed remote builds in B24618: Diff 58102.May 31 2019, 3:45 AM
andrew accepted this revision.May 31 2019, 9:49 AM
This revision is now accepted and ready to land.May 31 2019, 9:49 AM
Closed by commit rS349345: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR (authored by jchandra). · Explain WhyJun 24 2019, 9:00 PM
This revision was automatically updated to reflect the committed changes.
jchandra added a commit: rS349345: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
4 lines
3 lines

Diff 58967

View Options

head/sys/arm64/arm64/gic_v3.c

Loading...
View Options

head/sys/arm64/arm64/gic_v3_var.h

Loading...