It's implied by the RETURN VALUES section but be explicit in the description that vm_map_protect can not set new protection bits that are already in each entry's max_protection.
(Prompted by a comment/review in D18880.)
Details
Details
- Reviewers
markj brooks kib - Group Reviewers
manpages - Commits
- rS349239: Clarify that vm_map_protect cannot upgrade max_protection
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| share/man/man9/vm_map_protect.9 | ||
|---|---|---|
| 66 ↗ | (On Diff #58833) | It is probably noting that this case also (IIRC) demotes any existing permissions (vs bailing if they would not be permitted). |
| share/man/man9/vm_map_protect.9 | ||
|---|---|---|
| 66 ↗ | (On Diff #58833) | *worth noting |
| share/man/man9/vm_map_protect.9 | ||
|---|---|---|
| 66 ↗ | (On Diff #58833) | Yeah - I'll confirm and commit another change. |
| share/man/man9/vm_map_protect.9 | ||
|---|---|---|
| 66 ↗ | (On Diff #58833) | yes, old_prot = current->protection;
if (set_max)
current->protection =
(current->max_protection = new_prot) &
old_prot;
else
current->protection = new_prot; |