Page MenuHomeFreeBSD
Differential D20702

libelftc: Use size_t for string table size hints.
ClosedPublic
Actions

Authored by markj on Jun 19 2019, 8:54 PM.
Tags
None
Referenced Files
F166193251: D20702.id58807.diff
Wed, Aug 12, 6:41 AM
Unknown Object (File)
Sat, Aug 8, 10:34 PM
Unknown Object (File)
Sat, Aug 8, 5:53 PM
Unknown Object (File)
Fri, Aug 7, 4:17 PM
Unknown Object (File)
Sun, Aug 2, 12:00 PM
Unknown Object (File)
Mon, Jul 27, 12:23 AM
Unknown Object (File)
Sat, Jul 25, 6:43 AM
Unknown Object (File)
Sat, Jul 25, 3:06 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
Group Reviewers
manpages
Commits
rS349421: libelftc: Consistently use size_t for string table offsets and sizes.
Summary

String table offsets are returned as a size_t, so we might as well be
consistent.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24944
Build 23668: arc lint + arc unit

Event Timeline

markj created this revision.Jun 19 2019, 8:54 PM
Harbormaster completed remote builds in B24943: Diff 58807.Jun 19 2019, 8:54 PM
markj added a reviewer: emaste.Jun 19 2019, 8:54 PM
markj planned changes to this revision.Jun 19 2019, 8:58 PM

This is incomplete.

markj updated this revision to Diff 58808.Jun 19 2019, 9:15 PM

Consistently use (s)size_t for table size and offsets.

Deleted entries have a negative offset, so we use ssize_t there.

Harbormaster completed remote builds in B24944: Diff 58808.Jun 19 2019, 9:15 PM
emaste accepted this revision.Jun 21 2019, 1:13 PM
This revision is now accepted and ready to land.Jun 21 2019, 1:13 PM
Closed by commit rS349421: libelftc: Consistently use size_t for string table offsets and sizes. (authored by markj). · Explain WhyJun 26 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS349421: libelftc: Consistently use size_t for string table offsets and sizes..
Herald added a reviewer: manpages. · View Herald TranscriptJun 26 2019, 4:32 PM
Herald added a subscriber: imp. · View Herald Transcript
dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
libelftc/
35 lines
6 lines
4 lines

Diff 58808

View Options

contrib/elftoolchain/libelftc/elftc_string_table.c

Loading...
View Options

contrib/elftoolchain/libelftc/elftc_string_table_create.3

Loading...
View Options

contrib/elftoolchain/libelftc/libelftc.h

Loading...