Paths

Table of Contentst

Differential D20650

vtfontcvt: improve BDF and hex font parsing
ClosedPublic
Actions

Authored by emaste on Jun 15 2019, 12:30 PM.

Tags

None

Referenced Files

	F152258055: D20650.id58688.diff
	Mon, Apr 13, 5:50 PM

	F152195451: D20650.id58661.diff
	Mon, Apr 13, 8:57 AM

	Unknown Object (File)
	Sat, Apr 11, 3:02 PM

	Unknown Object (File)
	Tue, Apr 7, 5:59 AM

	Unknown Object (File)
	Mon, Apr 6, 11:17 AM

	Unknown Object (File)
	Sun, Mar 29, 10:24 PM

	Unknown Object (File)
	Sun, Mar 22, 2:29 PM

	Unknown Object (File)
	Sun, Mar 22, 11:46 AM

Subscribers

Details

Reviewers: None
Commits: rS349100: vtfontcvt: improve BDF and hex font parsing

Summary

Support larger font sizes.

PR: 205707
Submitted by: Dmitry Wagin (original version)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Jun 15 2019, 12:30 PM

emaste added a subscriber: 0mp.Jun 15 2019, 12:35 PM

Can use spleen font for testing.

Correct typo (; instead of , in variable definition)

Works on my 2560x1440 screen.

emaste added a child revision: D20654: Add spleen vt(4) fonts.Jun 15 2019, 1:35 PM

emaste mentioned this in D20654: Add spleen vt(4) fonts.

0mp added inline comments.Jun 15 2019, 1:57 PM

usr.bin/vtfontcvt/vtfontcvt.c
245	Would it be cleaner if it was a for loop instead?

emaste added inline comments.Jun 16 2019, 9:02 AM

usr.bin/vtfontcvt/vtfontcvt.c
245	Slightly awkward because the `i--` is at the beginning of the body not the end. I find the implementation of the `rshift_row` function a little unusual but will commit the submitted / tested version, perhaps rework it later.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2019, 9:17 AM

Closed by commit rS349100: vtfontcvt: improve BDF and hex font parsing (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS349100: vtfontcvt: improve BDF and hex font parsing.

Herald added a subscriber: imp. · View Herald TranscriptJun 16 2019, 9:17 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

vtfontcvt/

292 lines

Diff 58666

usr.bin/vtfontcvt/vtfontcvt.c

Loading...