Page MenuHomeFreeBSD

vtfontcvt: improve BDF and hex font parsing
ClosedPublic

Authored by emaste on Jun 15 2019, 12:30 PM.
Tags
None
Referenced Files
F132339221: D20650.id.diff
Thu, Oct 16, 1:18 AM
F132272203: D20650.id58661.diff
Wed, Oct 15, 9:40 AM
F132272202: D20650.id.diff
Wed, Oct 15, 9:40 AM
F132272195: D20650.id58666.diff
Wed, Oct 15, 9:40 AM
F132272194: D20650.id58688.diff
Wed, Oct 15, 9:40 AM
Unknown Object (File)
Tue, Oct 14, 10:58 PM
Unknown Object (File)
Fri, Oct 10, 2:33 AM
Unknown Object (File)
Mon, Sep 29, 12:41 AM
Subscribers

Details

Summary

Support larger font sizes.

PR: 205707
Submitted by: Dmitry Wagin (original version)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Correct typo (; instead of , in variable definition)

Works on my 2560x1440 screen.

usr.bin/vtfontcvt/vtfontcvt.c
245 ↗(On Diff #58666)

Would it be cleaner if it was a for loop instead?

usr.bin/vtfontcvt/vtfontcvt.c
245 ↗(On Diff #58666)

Slightly awkward because the i-- is at the beginning of the body not the end. I find the implementation of the rshift_row function a little unusual but will commit the submitted / tested version, perhaps rework it later.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2019, 9:17 AM
This revision was automatically updated to reflect the committed changes.