Page MenuHomeFreeBSD
Differential D20650

vtfontcvt: improve BDF and hex font parsing
ClosedPublic
Actions

Authored by emaste on Jun 15 2019, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 2:33 AM
Unknown Object (File)
Mon, Sep 29, 12:41 AM
Unknown Object (File)
Mon, Sep 29, 12:34 AM
Unknown Object (File)
Mon, Sep 29, 12:34 AM
Unknown Object (File)
Mon, Sep 29, 12:34 AM
Unknown Object (File)
Mon, Sep 29, 12:27 AM
Unknown Object (File)
Mon, Sep 29, 12:24 AM
Unknown Object (File)
Mon, Sep 29, 12:23 AM
View All Files
Subscribers
0mp
imp

Details

Reviewers
None
Commits
rS349100: vtfontcvt: improve BDF and hex font parsing
Summary

Support larger font sizes.

PR: 205707
Submitted by: Dmitry Wagin (original version)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Jun 15 2019, 12:30 PM
emaste added a subscriber: 0mp.Jun 15 2019, 12:35 PM
emaste added a comment.Jun 15 2019, 12:45 PM

Can use spleen font for testing.

emaste updated this revision to Diff 58666.Jun 15 2019, 1:17 PM

Correct typo (; instead of , in variable definition)

0mp added a comment.Jun 15 2019, 1:22 PM

Works on my 2560x1440 screen.

emaste added a child revision: D20654: Add spleen vt(4) fonts.Jun 15 2019, 1:35 PM
emaste mentioned this in D20654: Add spleen vt(4) fonts.
0mp added inline comments.Jun 15 2019, 1:57 PM
usr.bin/vtfontcvt/vtfontcvt.c
245 ↗(On Diff #58666)

Would it be cleaner if it was a for loop instead?

emaste added inline comments.Jun 16 2019, 9:02 AM
usr.bin/vtfontcvt/vtfontcvt.c
245 ↗(On Diff #58666)

Slightly awkward because the i-- is at the beginning of the body not the end. I find the implementation of the rshift_row function a little unusual but will commit the submitted / tested version, perhaps rework it later.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2019, 9:17 AM
Closed by commit rS349100: vtfontcvt: improve BDF and hex font parsing (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS349100: vtfontcvt: improve BDF and hex font parsing.
Herald added a subscriber: imp. · View Herald TranscriptJun 16 2019, 9:17 AM

Revision Contents
Changeset List

PathSize
head/
usr.bin/
vtfontcvt/
292 lines

Diff 58688

View Options

head/usr.bin/vtfontcvt/vtfontcvt.c

Loading...