Page MenuHomeFreeBSD

vtfontcvt: improve BDF and hex font parsing
ClosedPublic

Authored by emaste on Jun 15 2019, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:19 PM
Unknown Object (File)
Wed, Nov 20, 11:25 PM
Unknown Object (File)
Wed, Nov 20, 10:18 AM
Unknown Object (File)
Tue, Nov 19, 8:41 AM
Unknown Object (File)
Tue, Nov 19, 8:34 AM
Unknown Object (File)
Tue, Nov 19, 6:08 AM
Unknown Object (File)
Mon, Nov 4, 7:55 PM
Unknown Object (File)
Oct 19 2024, 11:26 PM
Subscribers

Details

Summary

Support larger font sizes.

PR: 205707
Submitted by: Dmitry Wagin (original version)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Correct typo (; instead of , in variable definition)

Works on my 2560x1440 screen.

usr.bin/vtfontcvt/vtfontcvt.c
245

Would it be cleaner if it was a for loop instead?

usr.bin/vtfontcvt/vtfontcvt.c
245

Slightly awkward because the i-- is at the beginning of the body not the end. I find the implementation of the rshift_row function a little unusual but will commit the submitted / tested version, perhaps rework it later.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2019, 9:17 AM
This revision was automatically updated to reflect the committed changes.