Page MenuHomeFreeBSD

vtfontcvt: improve BDF and hex font parsing
ClosedPublic

Authored by emaste on Jun 15 2019, 12:30 PM.

Details

Summary

Support larger font sizes.

PR: 205707
Submitted by: Dmitry Wagin (original version)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste created this revision.Jun 15 2019, 12:30 PM
emaste added a subscriber: 0mp.Jun 15 2019, 12:35 PM

Can use spleen font for testing.

emaste updated this revision to Diff 58666.Jun 15 2019, 1:17 PM

Correct typo (; instead of , in variable definition)

0mp added a comment.Jun 15 2019, 1:22 PM

Works on my 2560x1440 screen.

0mp added inline comments.Jun 15 2019, 1:57 PM
usr.bin/vtfontcvt/vtfontcvt.c
245–246

Would it be cleaner if it was a for loop instead?

emaste added inline comments.Jun 16 2019, 9:02 AM
usr.bin/vtfontcvt/vtfontcvt.c
245–246

Slightly awkward because the i-- is at the beginning of the body not the end. I find the implementation of the rshift_row function a little unusual but will commit the submitted / tested version, perhaps rework it later.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2019, 9:17 AM
This revision was automatically updated to reflect the committed changes.