Page MenuHomeFreeBSD

vtfontcvt: improve BDF and hex font parsing
ClosedPublic

Authored by emaste on Jun 15 2019, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 2:20 AM
Unknown Object (File)
Jan 13 2024, 10:13 AM
Unknown Object (File)
Dec 29 2023, 4:59 AM
Unknown Object (File)
Nov 6 2023, 1:45 AM
Unknown Object (File)
Nov 4 2023, 11:56 PM
Unknown Object (File)
Oct 19 2023, 1:22 AM
Unknown Object (File)
Oct 17 2023, 11:52 PM
Unknown Object (File)
Sep 15 2023, 3:47 AM
Subscribers

Details

Summary

Support larger font sizes.

PR: 205707
Submitted by: Dmitry Wagin (original version)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Correct typo (; instead of , in variable definition)

Works on my 2560x1440 screen.

usr.bin/vtfontcvt/vtfontcvt.c
245–246

Would it be cleaner if it was a for loop instead?

usr.bin/vtfontcvt/vtfontcvt.c
245–246

Slightly awkward because the i-- is at the beginning of the body not the end. I find the implementation of the rshift_row function a little unusual but will commit the submitted / tested version, perhaps rework it later.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2019, 9:17 AM
This revision was automatically updated to reflect the committed changes.