Differential D20488

Fix comment in sofree() to reference sbdestroy().
ClosedPublic
Actions

Authored by jhb on May 31 2019, 10:19 PM.

Tags

None

Referenced Files

	F173846629: D20488.id59130.diff
	Mon, Sep 28, 9:03 PM

	F173846492: D20488.id58134.diff
	Mon, Sep 28, 9:01 PM

	F173836546: D20488.diff
	Mon, Sep 28, 7:24 PM

	Unknown Object (File)
	Tue, Sep 22, 6:47 AM

	Unknown Object (File)
	Tue, Sep 22, 6:40 AM

	Unknown Object (File)
	Tue, Sep 22, 6:25 AM

	Unknown Object (File)
	Sun, Sep 20, 3:52 PM

	Unknown Object (File)
	Sun, Sep 20, 5:30 AM

Subscribers

Details

Reviewers

rwatson

Commits

rS349475: Fix comment in sofree() to reference sbdestroy().

Summary

r160875 added sbdestroy() as a wrapper around sbrelease_internal to
be called from sofree(), yet the comment added in the same revision
to sofree() still mentions sbrelease_internal().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24640
Build 23417: arc lint + arc unit

Event Timeline

jhb created this revision.May 31 2019, 10:19 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2019, 10:19 PM

Harbormaster completed remote builds in B24640: Diff 58134.May 31 2019, 10:19 PM

Other parts of this comment are a bit rotted and need updating. For example, we now invoke pru_detach() and dom_dispose() before this comment. That means the last paragraph is now wrong / obsolete and needs to be removed I think. Not clear if the calls to pru_detach and dom_dispose should be below this comment or not.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2019, 10:50 PM

Closed by commit rS349475: Fix comment in sofree() to reference sbdestroy(). (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS349475: Fix comment in sofree() to reference sbdestroy()..