Page MenuHomeFreeBSD
Differential D20476

makesyscalls.sh: always use absolute path for syscalls.conf
ClosedPublic
Actions

Authored by brooks on May 30 2019, 8:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 3:45 PM
Unknown Object (File)
Mon, Sep 7, 11:39 AM
Unknown Object (File)
Sun, Sep 6, 11:50 PM
Unknown Object (File)
Sun, Sep 6, 5:03 AM
Unknown Object (File)
Sun, Sep 6, 2:50 AM
Unknown Object (File)
Sun, Sep 6, 12:07 AM
Unknown Object (File)
Sat, Sep 5, 2:56 PM
Unknown Object (File)
Fri, Sep 4, 1:43 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
bdrewery
manu
Commits
rS351567: MFC r348446:
rS348446: makesyscalls.sh: always use absolute path for syscalls.conf
Summary

syscalls.conf is included using "." which per the Open Group:

If file does not contain a <slash>, the shell shall use the search path
specified by PATH to find the directory containing file.

POSIX shells don't fall back to the current working directory.

Submitted by: Nathaniel Wesley Filardo <nwf20@cl.cam.ac.uk>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24609
Build 23392: arc lint + arc unit

Event Timeline

brooks created this revision.May 30 2019, 8:34 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 30 2019, 8:34 PM
Herald added subscribers: emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B24609: Diff 58091.May 30 2019, 8:34 PM
bdrewery requested changes to this revision.May 30 2019, 8:43 PM
bdrewery added inline comments.
sys/compat/cloudabi64/Makefile
15

Please use ${.CURDIR} instead of ./ in all of this. That will churn less with my change which does that.

This revision now requires changes to proceed.May 30 2019, 8:43 PM
brooks updated this revision to Diff 58093.May 30 2019, 8:47 PM
  • Use ${.CURDIR} instead of ".".
Harbormaster completed remote builds in B24610: Diff 58093.May 30 2019, 8:47 PM
bdrewery accepted this revision.May 30 2019, 8:50 PM
This revision is now accepted and ready to land.May 30 2019, 8:50 PM
brooks retitled this revision from makesyscalls.sh: always use relative path for syscalls.conf to makesyscalls.sh: always use absolute path for syscalls.conf.May 30 2019, 8:54 PM
Closed by commit rS348446: makesyscalls.sh: always use absolute path for syscalls.conf (authored by brooks). · Explain WhyMay 30 2019, 8:56 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 30 2019, 8:56 PM
brooks added a commit: rS351567: MFC r348446:.Aug 28 2019, 8:05 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
4 lines
linux32/
4 lines
arm64/
linux/
4 lines
compat/
cloudabi32/
4 lines
cloudabi64/
4 lines
freebsd32/
4 lines
i386/
linux/
4 lines
kern/
2 lines

Diff 58091

View Options

sys/amd64/linux/Makefile

Loading...
View Options

sys/amd64/linux32/Makefile

Loading...
View Options

sys/arm64/linux/Makefile

Loading...
View Options

sys/compat/cloudabi32/Makefile

Loading...
View Options

sys/compat/cloudabi64/Makefile

Loading...
View Options

sys/compat/freebsd32/Makefile

Loading...
View Options

sys/i386/linux/Makefile

Loading...
View Options

sys/kern/makesyscalls.sh

Loading...