Page MenuHomeFreeBSD
Differential D20443

libelf: Use a red-black tree to manage sections
ClosedPublic
Actions

Authored by markj on May 28 2019, 3:29 PM.
Tags
None
Referenced Files
F167441290: D20443.diff
Fri, Aug 21, 6:52 PM
F167397143: D20443.diff
Fri, Aug 21, 1:13 PM
Unknown Object (File)
Tue, Aug 18, 3:23 AM
Unknown Object (File)
Mon, Aug 10, 1:40 PM
Unknown Object (File)
Mon, Aug 10, 12:23 AM
Unknown Object (File)
Sat, Aug 8, 5:57 PM
Unknown Object (File)
Sat, Aug 8, 5:34 PM
Unknown Object (File)
Sat, Aug 8, 4:53 PM
View All Files
Subscribers
arrowd
csjp
imp

Details

Reviewers
emaste
kaiw
jkoshy_users.sourceforge.net
Commits
rS348652: libelf: Use a red-black tree to manage the section list.
Summary

The tree is indexed by section number. This speeds up elf_getscn(3),
which in turn helps other functions. For example, elf_strptr() needs to
look up .shstrtab, which is typically the last section.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24559
Build 23345: arc lint + arc unit

Event Timeline

markj created this revision.May 28 2019, 3:29 PM
Harbormaster completed remote builds in B24559: Diff 57994.May 28 2019, 3:29 PM
markj added reviewers: emaste, kaiw, jkoshy_users.sourceforge.net.May 28 2019, 3:30 PM
markj updated this revision to Diff 57997.May 28 2019, 3:34 PM
  • Remove unintentional change.
Harbormaster completed remote builds in B24562: Diff 57997.May 28 2019, 3:34 PM
arrowd added a subscriber: arrowd.Jun 1 2019, 7:56 PM
emaste added a subscriber: csjp.Jun 4 2019, 3:47 PM
emaste added a comment.Jun 4 2019, 3:50 PM

sys/tree.h works on all supported operating systems? (for upstreaming)

Overall LGTM

markj added a comment.Jun 4 2019, 3:52 PM
In D20443#443056, @emaste wrote:

sys/tree.h works on all supported operating systems? (for upstreaming)

Yes, it comes with libbsd, which is already required for queue.h etc..

emaste accepted this revision.Jun 4 2019, 3:57 PM
This revision is now accepted and ready to land.Jun 4 2019, 3:57 PM
Closed by commit rS348652: libelf: Use a red-black tree to manage the section list. (authored by markj). · Explain WhyJun 4 2019, 6:26 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJun 4 2019, 6:26 PM
dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
libelf/
8 lines
5 lines
31 lines
6 lines
8 lines
2 lines
2 lines

Diff 57994

View Options

contrib/elftoolchain/libelf/_libelf.h

Loading...
View Options

contrib/elftoolchain/libelf/elf_end.c

Loading...
View Options

contrib/elftoolchain/libelf/elf_scn.c

Loading...
View Options

contrib/elftoolchain/libelf/elf_update.c

Loading...
View Options

contrib/elftoolchain/libelf/libelf_allocate.c

Loading...
View Options

contrib/elftoolchain/libelf/libelf_ehdr.c

Loading...
View Options

contrib/elftoolchain/libelf/libelf_extended.c

Loading...