Page MenuHomeFreeBSD
Differential D20387

ficl pfopen: verify file
ClosedPublic
Actions

Authored by sjg on May 23 2019, 8:10 PM.
Tags
None
Referenced Files
F167953562: D20387.diff
Tue, Aug 25, 2:49 PM
F167952899: D20387.id.diff
Tue, Aug 25, 2:42 PM
Unknown Object (File)
Mon, Aug 24, 9:12 AM
Unknown Object (File)
Mon, Aug 24, 9:12 AM
Unknown Object (File)
Sun, Aug 23, 7:47 AM
Unknown Object (File)
Sat, Aug 22, 8:40 PM
Unknown Object (File)
Sat, Aug 22, 8:34 PM
Unknown Object (File)
Sat, Aug 22, 8:06 PM
View All Files
Subscribers
imp

Details

Reviewers
kd
stevek
Commits
rS348449: ficl pfopen: verify file
rS348249: ficl pfopen: verify file
Summary

If the file is verified - do not allow write
otherwise do not allow read.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24454
Build 23262: arc lint + arc unit

Event Timeline

sjg created this revision.May 23 2019, 8:10 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 23 2019, 8:10 PM
Harbormaster completed remote builds in B24447: Diff 57796.May 23 2019, 8:10 PM
sjg updated this revision to Diff 57797.May 23 2019, 8:14 PM

Add ficl.mk

Harbormaster completed remote builds in B24448: Diff 57797.May 23 2019, 8:14 PM
sjg added reviewers: kd, stevek.May 23 2019, 8:15 PM
stevek added inline comments.May 23 2019, 9:27 PM
stand/ficl/loader.c
509

I believe this should be written like so:
if ((mode & O_ACCMODE) != O_WRONLY) {

515

Similar thing here:
if ((mode & O_ACCMODE) != O_RDONLY) {

sjg updated this revision to Diff 57803.May 23 2019, 9:33 PM

Use O_ACCMODE

Harbormaster completed remote builds in B24452: Diff 57803.May 23 2019, 9:33 PM
sjg marked 2 inline comments as done.May 23 2019, 9:33 PM

Good point

sjg updated this revision to Diff 57805.May 23 2019, 9:43 PM

stand.h needs to define O_ACCMODE

Harbormaster completed remote builds in B24454: Diff 57805.May 23 2019, 9:43 PM
kd accepted this revision.May 24 2019, 7:33 AM

Did some basic testing and it looks ok.

This revision is now accepted and ready to land.May 24 2019, 7:33 AM
stevek accepted this revision.May 24 2019, 5:58 PM
Closed by commit rS348249: ficl pfopen: verify file (authored by sjg). · Explain WhyMay 24 2019, 7:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
4 lines
ficl/
17 lines
libsa/
1 line

Diff 57805

View Options

stand/ficl.mk

Loading...
View Options

stand/ficl/loader.c

Loading...
View Options

stand/libsa/stand.h

Loading...