Page MenuHomeFreeBSD

ficl pfopen: verify file
ClosedPublic

Authored by sjg on May 23 2019, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 4:32 AM
Unknown Object (File)
Mon, Mar 11, 8:27 AM
Unknown Object (File)
Mon, Mar 11, 8:27 AM
Unknown Object (File)
Mon, Mar 11, 8:27 AM
Unknown Object (File)
Mon, Mar 11, 8:27 AM
Unknown Object (File)
Mon, Mar 11, 8:27 AM
Unknown Object (File)
Mon, Mar 11, 8:26 AM
Unknown Object (File)
Thu, Mar 7, 10:50 PM
Subscribers

Details

Summary

If the file is verified - do not allow write
otherwise do not allow read.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

stand/ficl/loader.c
509 ↗(On Diff #57797)

I believe this should be written like so:
if ((mode & O_ACCMODE) != O_WRONLY) {

515 ↗(On Diff #57797)

Similar thing here:
if ((mode & O_ACCMODE) != O_RDONLY) {

sjg marked 2 inline comments as done.May 23 2019, 9:33 PM

Good point

stand.h needs to define O_ACCMODE

Did some basic testing and it looks ok.

This revision is now accepted and ready to land.May 24 2019, 7:33 AM
This revision was automatically updated to reflect the committed changes.