Tags

None

Referenced Files

	F167628709: D20387.id57805.diff
	Sun, Aug 23, 7:47 AM

	F167580249: D20387.id.diff
	Sat, Aug 22, 8:40 PM

	F167579784: D20387.id57797.diff
	Sat, Aug 22, 8:34 PM

	F167577462: D20387.diff
	Sat, Aug 22, 8:06 PM

	Unknown Object (File)
	Sat, Aug 15, 6:22 AM

	Unknown Object (File)
	Wed, Aug 12, 5:57 AM

	Unknown Object (File)
	Wed, Aug 12, 5:55 AM

	Unknown Object (File)
	Wed, Aug 12, 12:01 AM

View All Files

Subscribers

imp

Details

Reviewers

kd
stevek

Commits

rS348449: ficl pfopen: verify file
rS348249: ficl pfopen: verify file

Summary

If the file is verified - do not allow write
otherwise do not allow read.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24447
Build 23256: arc lint + arc unit

Event Timeline

sjg created this revision.May 23 2019, 8:10 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2019, 8:10 PM

Harbormaster completed remote builds in B24447: Diff 57796.May 23 2019, 8:10 PM

Add ficl.mk

Harbormaster completed remote builds in B24448: Diff 57797.May 23 2019, 8:14 PM

sjg added reviewers: kd, stevek.May 23 2019, 8:15 PM

stevek added inline comments.May 23 2019, 9:27 PM

stand/ficl/loader.c
509	I believe this should be written like so: if ((mode & O_ACCMODE) != O_WRONLY) {
515	Similar thing here: if ((mode & O_ACCMODE) != O_RDONLY) {

Use O_ACCMODE

Harbormaster completed remote builds in B24452: Diff 57803.May 23 2019, 9:33 PM

Good point

stand.h needs to define O_ACCMODE

Harbormaster completed remote builds in B24454: Diff 57805.May 23 2019, 9:43 PM

Did some basic testing and it looks ok.

This revision is now accepted and ready to land.May 24 2019, 7:33 AM

stevek accepted this revision.May 24 2019, 5:58 PM

Closed by commit rS348249: ficl pfopen: verify file (authored by sjg). · Explain WhyMay 24 2019, 7:44 PM

This revision was automatically updated to reflect the committed changes.

ficl pfopen: verify file
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 57796

stand/ficl/loader.c

ficl pfopen: verify fileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 57796

stand/ficl/loader.c

ficl pfopen: verify file
ClosedPublic
Actions

Revision Contents
Changeset List