Page MenuHomeFreeBSD
Differential D20364

DTrace: create an amd64 test suit
ClosedPublic
Actions

Authored by oshogbo on May 22 2019, 7:49 PM.
Tags
None
Referenced Files
F114600098: D20364.diff
Mon, Apr 14, 7:39 AM
F114580388: D20364.id.diff
Mon, Apr 14, 3:44 AM
F114550964: D20364.id58284.diff
Sun, Apr 13, 10:04 PM
F114549370: D20364.id57727.diff
Sun, Apr 13, 9:46 PM
F114548473: D20364.id57725.diff
Sun, Apr 13, 9:38 PM
F114543291: D20364.id57721.diff
Sun, Apr 13, 8:35 PM
F114539193: D20364.id57719.diff
Sun, Apr 13, 7:26 PM
Unknown Object (File)
Wed, Apr 2, 2:10 AM
View All 100 Files
Subscribers
imp

Details

Reviewers
markj
gnn
emaste
Commits
rS348706: DTrace: create an amd64 test suit
Summary

Create two tests checking if we can read urgs registers and if the
rax register returns a correct number.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24412
Build 23228: arc lint + arc unit

Event Timeline

oshogbo created this revision.May 22 2019, 7:49 PM
Harbormaster completed remote builds in B24408: Diff 57719.May 22 2019, 7:49 PM
oshogbo added reviewers: markj, gnn, emaste.May 22 2019, 7:50 PM
markj added inline comments.May 22 2019, 8:21 PM
cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/arrays/tst.rax.c
33

Add rax to the clobber list?

oshogbo updated this revision to Diff 57721.May 22 2019, 8:49 PM

Address @markj suggestions.

Harbormaster completed remote builds in B24409: Diff 57721.May 22 2019, 8:49 PM
oshogbo marked an inline comment as done.May 22 2019, 8:50 PM
markj added inline comments.May 22 2019, 9:11 PM
cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/arrays/tst.rax.d
30

The ident pragma shouldn't be added to new files.

oshogbo updated this revision to Diff 57725.May 22 2019, 9:14 PM

Remove pragma.

Harbormaster completed remote builds in B24411: Diff 57725.May 22 2019, 9:14 PM
oshogbo marked an inline comment as done.May 22 2019, 9:15 PM
oshogbo updated this revision to Diff 57727.May 22 2019, 9:20 PM

Remove pragma 2.

Harbormaster completed remote builds in B24412: Diff 57727.May 22 2019, 9:20 PM
markj accepted this revision.May 22 2019, 9:52 PM

Thanks for doing this.

This revision is now accepted and ready to land.May 22 2019, 9:52 PM
Closed by commit rS348706: DTrace: create an amd64 test suit (authored by oshogbo). · Explain WhyJun 5 2019, 10:32 PM
This revision was automatically updated to reflect the committed changes.
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJun 5 2019, 10:32 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
dtrace/
test/
tst/
amd64/
arrays/
43 lines
36 lines
82 lines
usr.sbin/
dtrace/
tests/
4 lines
amd64/
arrays/
20 lines
tools/
2 lines
etc/
mtree/
4 lines

Diff 57727

View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/arrays/tst.rax.c

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/arrays/tst.rax.d

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/arrays/tst.uregsarray.d

Loading...
View Options

cddl/usr.sbin/dtrace/tests/Makefile

Loading...
View Options

cddl/usr.sbin/dtrace/tests/amd64/arrays/Makefile

Loading...
View Options

cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh

Loading...
View Options

etc/mtree/BSD.tests.dist

Loading...