Restore x18 in efi_arch_leave
ClosedPublic
Actions

Authored by andrew on May 1 2019, 4:04 PM.

Details

Reviewers

manu

Group Reviewers

arm64

Commits

rS352395: MFC r346996:
rS346996: Restore x18 in efi_arch_leave.

Summary

Some UEFI implementations trash this register and, as we use it as
a platform register, the kernel doesn't save it before calling into
the UEFI runtime services. As we have a copy in tpidr_el1 restore from
there when exiting the EFI environment.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24038
Build 22923: arc lint + arc unit

Event Timeline

andrew created this revision.May 1 2019, 4:04 PM

Herald added a subscriber: emaste. · View Herald TranscriptMay 1 2019, 4:04 PM

Harbormaster completed remote builds in B24037: Diff 56909.May 1 2019, 4:04 PM

Move loading x18 before we use it.

Harbormaster completed remote builds in B24038: Diff 56913.May 1 2019, 4:23 PM

Also :

Tested On: Ampere eMAG

This revision is now accepted and ready to land.May 1 2019, 4:31 PM

Should we add a Sponsored by: Ampere Computing (hardware)?

And PRs 237234, 237055

Yes (for both)

(And Andy's Sponsored-by, of course)

Closed by commit rS346996: Restore x18 in efi_arch_leave. (authored by andrew). · Explain WhyMay 1 2019, 5:13 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 1 2019, 5:13 PM

andrew added a commit: rS352395: MFC r346996:.Sep 16 2019, 1:45 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

efirt_machdep.c

10 lines

Diff 56913

View Options

sys/arm64/arm64/efirt_machdep.c

Restore x18 in efi_arch_leaveClosedPublicActions