Page MenuHomeFreeBSD

Restore x18 in efi_arch_leave
ClosedPublic

Authored by andrew on May 1 2019, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 1, 6:31 PM
Unknown Object (File)
Wed, Jul 23, 3:28 PM
Unknown Object (File)
Wed, Jul 23, 4:12 AM
Unknown Object (File)
Fri, Jul 11, 11:08 AM
Unknown Object (File)
Jun 27 2025, 10:54 AM
Unknown Object (File)
Jun 25 2025, 5:22 AM
Unknown Object (File)
Jun 13 2025, 11:56 AM
Unknown Object (File)
Jun 12 2025, 11:54 AM
Subscribers

Details

Summary

Some UEFI implementations trash this register and, as we use it as
a platform register, the kernel doesn't save it before calling into
the UEFI runtime services. As we have a copy in tpidr_el1 restore from
there when exiting the EFI environment.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24038
Build 22923: arc lint + arc unit

Event Timeline

Move loading x18 before we use it.

Also :

Tested On: Ampere eMAG

This revision is now accepted and ready to land.May 1 2019, 4:31 PM

Should we add a Sponsored by: Ampere Computing (hardware)?

(And Andy's Sponsored-by, of course)

This revision was automatically updated to reflect the committed changes.