Differential D20043

Don't panic for empty CCM requests.
ClosedPublic
Actions

Authored by jhb on Apr 24 2019, 10:45 PM.

Tags

None

Referenced Files

	F105771928: D20043.diff
	Fri, Dec 20, 11:48 AM

	Unknown Object (File)
	Tue, Dec 3, 12:34 AM

	Unknown Object (File)
	Nov 16 2024, 6:31 PM

	Unknown Object (File)
	Nov 16 2024, 5:47 PM

	Unknown Object (File)
	Nov 16 2024, 3:34 PM

	Unknown Object (File)
	Oct 11 2024, 2:31 AM

	Unknown Object (File)
	Oct 6 2024, 8:05 AM

	Unknown Object (File)
	Sep 30 2024, 6:41 PM

View All 52 Files

Subscribers

imp

Details

Reviewers

sef
cem
jmg

Commits

rS346649: Don't panic for empty CCM requests.

Summary

A request to encrypt an empty payload without any AAD is unusual, but
it is defined behavior. Removing this assertion removes a panic and
instead returns the correct tag for an empty buffer.

Test Plan

'cryptocheck -d soft -va aes-ccm 0' now gets a result matching OpenSSL instead of triggering a panic

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 24 2019, 10:45 PM

Harbormaster completed remote builds in B23880: Diff 56612.Apr 24 2019, 10:45 PM

Something made me think that it was not acceptable, but now I can't remember what it was, so it's clearly wrong.

This revision is now accepted and ready to land.Apr 24 2019, 10:46 PM

Yeah, I think we talked about this in one of sef@'s reviews. It might've been a later one, though.

Closed by commit rS346649: Don't panic for empty CCM requests. (authored by jhb). · Explain WhyApr 24 2019, 11:27 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: jmg. · View Herald TranscriptApr 24 2019, 11:27 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

cbc_mac.c

3 lines

Diff 56613

View Options

head/sys/opencrypto/cbc_mac.c

Don't panic for empty CCM requests.ClosedPublicActions