Page MenuHomeFreeBSD

Don't panic for empty CCM requests.
ClosedPublic

Authored by jhb on Apr 24 2019, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 12:50 AM
Unknown Object (File)
Jan 21 2024, 5:10 AM
Unknown Object (File)
Dec 20 2023, 12:29 AM
Unknown Object (File)
Dec 7 2023, 6:25 AM
Unknown Object (File)
Nov 14 2023, 2:37 PM
Unknown Object (File)
Nov 10 2023, 4:11 PM
Unknown Object (File)
Nov 6 2023, 6:39 PM
Unknown Object (File)
Oct 13 2023, 1:36 PM
Subscribers

Details

Summary

A request to encrypt an empty payload without any AAD is unusual, but
it is defined behavior. Removing this assertion removes a panic and
instead returns the correct tag for an empty buffer.

Test Plan
  • 'cryptocheck -d soft -va aes-ccm 0' now gets a result matching OpenSSL instead of triggering a panic

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23880
Build 22810: arc lint + arc unit

Event Timeline

Something made me think that it was not acceptable, but now I can't remember what it was, so it's clearly wrong.

This revision is now accepted and ready to land.Apr 24 2019, 10:46 PM

Yeah, I think we talked about this in one of sef@'s reviews. It might've been a later one, though.

This revision was automatically updated to reflect the committed changes.