Page MenuHomeFreeBSD
Differential D19884

Run the plain SHA digest tests from NIST.
ClosedPublic
Actions

Authored by jhb on Apr 11 2019, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 18, 2:31 PM
Unknown Object (File)
Mon, Aug 17, 4:53 PM
Unknown Object (File)
Mon, Aug 17, 1:07 PM
Unknown Object (File)
Mon, Aug 17, 12:36 PM
Unknown Object (File)
Sun, Aug 16, 9:19 PM
Unknown Object (File)
Sun, Aug 16, 7:12 PM
Unknown Object (File)
Sun, Aug 16, 3:08 PM
Unknown Object (File)
Sun, Aug 16, 1:20 PM
View All Files
Subscribers
imp

Details

Reviewers
cem
jmg
Commits
rS346616: Run the plain SHA digest tests from NIST.
Summary

Pass in an explicit digest length to the Crypto constructor since it
was assuming only sessions with a MAC key would have a MAC. Passing
an explicit size allows us to test the full digest in HMAC tests as
well.

Test Plan
  • tested with cryptosoft0 and ccr0
  • this depends on the updated version of the nist-kat port that installs the plain SHA test vectors

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Apr 11 2019, 9:14 PM
Harbormaster completed remote builds in B23635: Diff 56111.Apr 11 2019, 9:14 PM
jhb added parent revisions: D19853: [security/nist-kat]: Add AES-CCM and plain SHA digest test vectors., D19881: Sync cryptographic algorithm constants with current cryptodev.h..Apr 11 2019, 9:14 PM
cem accepted this revision.Apr 11 2019, 9:28 PM
cem added inline comments.
tests/sys/opencrypto/cryptotest.py
266 ↗(On Diff #56111)

Because we don't support these algorithms?

This revision is now accepted and ready to land.Apr 11 2019, 9:28 PM
jhb added inline comments.Apr 11 2019, 9:44 PM
tests/sys/opencrypto/cryptotest.py
266 ↗(On Diff #56111)

Yes, at least not AFAIK. If it's just truncated SHA512 I could perhaps ask for SHA512 from OCF and truncate it manually.

cem added inline comments.Apr 11 2019, 9:56 PM
tests/sys/opencrypto/cryptotest.py
266 ↗(On Diff #56111)

Nah, like SHA-384, it has different initial constants. Can't just truncate ordinary SHA-512.

jhb added a parent revision: D20034: Skip tests with missing test vectors instead of failing..Apr 23 2019, 10:20 PM
Closed by commit rS346616: Run the plain SHA digest tests from NIST. (authored by jhb). · Explain WhyApr 24 2019, 12:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptApr 24 2019, 12:16 AM

Revision Contents
Changeset List

PathSize
head/
tests/
sys/
opencrypto/
6 lines
66 lines

Diff 56563

View Options

head/tests/sys/opencrypto/cryptodev.py

Loading...
View Options

head/tests/sys/opencrypto/cryptotest.py

Loading...