Page MenuHomeFreeBSD

Run the plain SHA digest tests from NIST.
ClosedPublic

Authored by jhb on Apr 11 2019, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 8:01 PM
Unknown Object (File)
Fri, Jan 17, 5:47 PM
Unknown Object (File)
Sun, Jan 12, 9:04 PM
Unknown Object (File)
Sat, Jan 4, 12:43 PM
Unknown Object (File)
Dec 5 2024, 12:34 PM
Unknown Object (File)
Dec 3 2024, 6:21 AM
Unknown Object (File)
Nov 25 2024, 3:08 AM
Unknown Object (File)
Oct 24 2024, 3:25 PM
Subscribers

Details

Summary

Pass in an explicit digest length to the Crypto constructor since it
was assuming only sessions with a MAC key would have a MAC. Passing
an explicit size allows us to test the full digest in HMAC tests as
well.

Test Plan
  • tested with cryptosoft0 and ccr0
  • this depends on the updated version of the nist-kat port that installs the plain SHA test vectors

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 23635
Build 22620: arc lint + arc unit

Event Timeline

cem added inline comments.
tests/sys/opencrypto/cryptotest.py
266

Because we don't support these algorithms?

This revision is now accepted and ready to land.Apr 11 2019, 9:28 PM
tests/sys/opencrypto/cryptotest.py
266

Yes, at least not AFAIK. If it's just truncated SHA512 I could perhaps ask for SHA512 from OCF and truncate it manually.

tests/sys/opencrypto/cryptotest.py
266

Nah, like SHA-384, it has different initial constants. Can't just truncate ordinary SHA-512.

This revision was automatically updated to reflect the committed changes.