Page MenuHomeFreeBSD

Push down INP_WLOCK slightly in tcp_ctloutput.
ClosedPublic

Authored by jhb on Mar 28 2019, 9:17 PM.
Tags
None
Referenced Files
F86129974: D19740.id56368.diff
Sat, Jun 15, 9:00 PM
F86116344: D19740.id56368.diff
Sat, Jun 15, 5:15 PM
Unknown Object (File)
Thu, May 23, 2:53 AM
Unknown Object (File)
Sun, May 19, 6:31 PM
Unknown Object (File)
Fri, May 17, 6:08 PM
Unknown Object (File)
May 7 2024, 5:23 PM
Unknown Object (File)
Feb 26 2024, 5:15 PM
Unknown Object (File)
Feb 10 2024, 9:36 PM
Subscribers

Details

Summary

The inp lock is not needed for testing the V6 flag as that flag is set
once when the inp is created and never changes. For non-TCP socket
options the lock is immediately dropped after checking that flag.
This just pushes the lock down to only be acquired for TCP socket
options.

This isn't a hot-path, more a cosmetic cleanup I noticed while reading
the code.

Test Plan
  • tested as part of larger patch by Drew (and myself in light testing)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable