Page MenuHomeFreeBSD

Push down INP_WLOCK slightly in tcp_ctloutput.
ClosedPublic

Authored by jhb on Mar 28 2019, 9:17 PM.
Tags
None
Referenced Files
F137933507: D19740.id55558.diff
Thu, Nov 27, 10:04 AM
F137901958: D19740.diff
Thu, Nov 27, 1:13 AM
Unknown Object (File)
Wed, Nov 26, 3:34 PM
Unknown Object (File)
Fri, Nov 21, 4:18 AM
Unknown Object (File)
Fri, Nov 21, 4:15 AM
Unknown Object (File)
Fri, Nov 21, 4:14 AM
Unknown Object (File)
Fri, Nov 21, 4:09 AM
Unknown Object (File)
Mon, Nov 17, 9:17 PM
Subscribers

Details

Summary

The inp lock is not needed for testing the V6 flag as that flag is set
once when the inp is created and never changes. For non-TCP socket
options the lock is immediately dropped after checking that flag.
This just pushes the lock down to only be acquired for TCP socket
options.

This isn't a hot-path, more a cosmetic cleanup I noticed while reading
the code.

Test Plan
  • tested as part of larger patch by Drew (and myself in light testing)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable