Paths

Table of Contentst

Differential D19847

Exercise some care before sending SIGHUP to mountd.
ClosedPublic
Actions

Authored by kib on Apr 8 2019, 3:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 8:56 AM

	Unknown Object (File)
	Fri, May 3, 8:49 AM

	Unknown Object (File)
	Fri, May 3, 8:49 AM

	Unknown Object (File)
	Fri, May 3, 8:05 AM

	Unknown Object (File)
	Fri, May 3, 5:56 AM

	Unknown Object (File)
	Mar 11 2024, 6:58 PM

	Unknown Object (File)
	Mar 11 2024, 6:58 PM

	Unknown Object (File)
	Mar 11 2024, 6:58 PM

View All 36 Files

Subscribers

Details

Reviewers

antoine
emaste
oshogbo

Commits

rS346038: Exercise some care before sending SIGHUP to mountd.

Summary

Do trivial checks for the mountd' pid validity before.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23569

Event Timeline

kib created this revision.Apr 8 2019, 3:36 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 8 2019, 3:36 PM

Harbormaster completed remote builds in B23568: Diff 55945.Apr 8 2019, 3:36 PM

Could we (also) add assertions in pidfile_open for this case?

sbin/mount/mount.c
243–244	This comment is historically correct, but really we should stop having such bugs - in any case, we don't expect to have more and the comment suggests it's just something that happens occasionally and we're powerless to stop. I would probably say "has happened due to ..."

This revision is now accepted and ready to land.Apr 8 2019, 3:52 PM

Update comment.

This revision now requires review to proceed.Apr 8 2019, 3:58 PM

Harbormaster completed remote builds in B23569: Diff 55946.Apr 8 2019, 3:58 PM

antoine accepted this revision.Apr 8 2019, 4:40 PM

This revision is now accepted and ready to land.Apr 8 2019, 4:40 PM

oshogbo accepted this revision.Apr 8 2019, 5:48 PM

emaste accepted this revision.Apr 8 2019, 6:04 PM

Closed by commit rS346038: Exercise some care before sending SIGHUP to mountd. (authored by kib). · Explain WhyApr 8 2019, 6:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sbin/

mount/

11 lines

Diff 55946

sbin/mount/mount.c

Loading...