vn_vmap_seekhole(): align running offset to the block boundary.
ClosedPublic
Actions

Authored by kib on Apr 3 2019, 2:08 PM.

Details

Reviewers

markj

Commits

rS345955: vn_vmap_seekhole(): align running offset to the block boundary.

Summary

Otherwise we might miss the last iteration where EOF appears below unaligned noff.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23511

Event Timeline

kib created this revision.Apr 3 2019, 2:08 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 3 2019, 2:08 PM

Harbormaster completed remote builds in B23490: Diff 55776.Apr 3 2019, 2:08 PM

kib mentioned this in D19599: Add a UFS-specific implementation for lseek(SEEK_DATA)..Apr 3 2019, 2:08 PM

emaste added a subscriber: emaste.Apr 3 2019, 2:48 PM

markj added inline comments.Apr 3 2019, 11:02 PM

sys/kern/vfs_vnops.c
2171	Shouldn't it be `noff += noff % bsize == 0 ? bsize : bsize - noff % bsize`? Or even `noff += bsize - noff % bsize`.

Fix invalid calculation of realignment.

Harbormaster completed remote builds in B23511: Diff 55802.Apr 4 2019, 1:11 PM

markj accepted this revision.Apr 4 2019, 11:06 PM

This revision is now accepted and ready to land.Apr 4 2019, 11:06 PM

Closed by commit rS345955: vn_vmap_seekhole(): align running offset to the block boundary. (authored by kib). · Explain WhyApr 5 2019, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_vnops.c

3 lines

Diff 55802

View Options

vn_vmap_seekhole(): align running offset to the block boundary.ClosedPublicActions