Use 'phy-handle' in FDT to find PHY address
ClosedPublic
Actions

Authored by aryeeteygerald_rogers.com on Apr 3 2019, 4:07 PM.

Details

Reviewers

Commits

rS345855: cpsw: use `phy-handle` in FDT to find PHY address

Summary

Based on @manu's patch.
Since 'phy_id' is no longer dts as per in r337703, update driver to match device tree.

Test Plan

Tested on a beaglebone black

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23496
Build 22503: arc lint + arc unit

sys/arm/ti/cpsw/if_cpsw.c
761–762	I don't think this is needed.

sys/arm/ti/cpsw/if_cpsw.c
761–762	I don't think this is needed. Yea, I think fdt_get_phyaddr should already handle it.
777	I think I should re-add this check in case a slave isn't found somehow ...

sys/arm/ti/cpsw/if_cpsw.c
763	This would return ENXIO if the first slave node isn't the one used, I don't know if any boards are like that but if they are they worked before and should after.

sys/arm/ti/cpsw/if_cpsw.c
763	You might also want to get phy_id if phy-handle don't exists so people with old DTB could still boot.

sys/arm/ti/cpsw/if_cpsw.c
763	Mhm no the old code only check the first slave@ node that matches the full node name based on the port and this is still the case. A correct way would be to rely on the 'slaves' property which contain the number of slaves used and always parse every slave until this number is reached instead of this but that might be out of the scope of this review. So just add a fallback to read phy_id if phy-handle doesn't exists and we're good to go for this one.