Create port for libpololu.
ClosedPublic
Actions

Authored by jonathan on May 22 2015, 2:35 PM.

Details

Reviewers

antoine
mat

Commits

rP397538: Add new port: devel/libpololu-avr.

Summary

This is a library used to control Pololu AVR-based robots such as the
Pololu 3pi (used for introductory programming education at Memorial
University of Newfoundland and, I believe, other places too).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

jonathan updated this revision to Diff 5559.May 22 2015, 2:35 PM

jonathan retitled this revision from to Create port for libpololu..

jonathan updated this object.

jonathan edited the test plan for this revision. (Show Details)

jonathan added reviewers: mat, antoine.

mat added inline comments.May 22 2015, 6:05 PM

devel/libpololu-avr/Makefile
6–7	Why twice ?
10	If it is a zip file, you also need USES=zip
22	As you're adding `-avr` everywhere, why not name the port `libpololu-avr` directly ? It would simplify a lot of things.

Remove duplicate MASTER_SITES.
Rename port to libpololu-avr.
Add USES=zip, since the distfile is a zip file.

This looks good, feel free to commit it with the USES line modified as per the comment I added.

Approved by: mat

devel/libpololu-avr/Makefile
23	You should remove this line, and add gmake to the USES line, because otherwise, the port won't depend on gmake, and it won't be there when it'll be built :-)

This revision is now accepted and ready to land.Jul 23 2015, 10:51 PM

Hi @mat,

Thanks very much! Just to be clear, as a src-only committer, does your comment mean that I ought to commit the change to the ports tree with an Approved by: mat line?

Thanks,

Jon

In D2622#69646, @jonathan wrote:

Thanks very much! Just to be clear, as a src-only committer, does your comment mean that I ought to commit the change to the ports tree with an Approved by: mat line?

Absolutely.

Closed by commit rP397538: Add new port: devel/libpololu-avr. (authored by jonathan). · Explain WhySep 22 2015, 1:48 PM

This revision was automatically updated to reflect the committed changes.

jonathan marked an inline comment as done.