Page MenuHomeFreeBSD

Push down INP_WLOCK slightly in tcp_ctloutput.
ClosedPublic

Authored by jhb on Mar 28 2019, 9:17 PM.
Tags
None
Referenced Files
F136109418: D19740.id56368.diff
Sat, Nov 15, 9:01 PM
F136041523: D19740.diff
Sat, Nov 15, 8:24 AM
Unknown Object (File)
Sat, Nov 1, 11:14 PM
Unknown Object (File)
Sat, Nov 1, 11:14 PM
Unknown Object (File)
Sat, Nov 1, 11:14 PM
Unknown Object (File)
Sat, Nov 1, 7:09 PM
Unknown Object (File)
Wed, Oct 29, 7:30 AM
Unknown Object (File)
Tue, Oct 28, 9:20 AM
Subscribers

Details

Summary

The inp lock is not needed for testing the V6 flag as that flag is set
once when the inp is created and never changes. For non-TCP socket
options the lock is immediately dropped after checking that flag.
This just pushes the lock down to only be acquired for TCP socket
options.

This isn't a hot-path, more a cosmetic cleanup I noticed while reading
the code.

Test Plan
  • tested as part of larger patch by Drew (and myself in light testing)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 23358
Build 22384: arc lint + arc unit