Page MenuHomeFreeBSD

Push down INP_WLOCK slightly in tcp_ctloutput.
ClosedPublic

Authored by jhb on Mar 28 2019, 9:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 7, 6:01 PM
Unknown Object (File)
Tue, Jul 1, 4:55 PM
Unknown Object (File)
Sun, Jun 29, 9:24 PM
Unknown Object (File)
Sun, Jun 29, 7:11 AM
Unknown Object (File)
Sat, Jun 28, 9:16 PM
Unknown Object (File)
Sat, Jun 28, 1:37 AM
Unknown Object (File)
Fri, Jun 27, 3:08 PM
Unknown Object (File)
Thu, Jun 26, 9:47 PM
Subscribers

Details

Summary

The inp lock is not needed for testing the V6 flag as that flag is set
once when the inp is created and never changes. For non-TCP socket
options the lock is immediately dropped after checking that flag.
This just pushes the lock down to only be acquired for TCP socket
options.

This isn't a hot-path, more a cosmetic cleanup I noticed while reading
the code.

Test Plan
  • tested as part of larger patch by Drew (and myself in light testing)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 23358
Build 22384: arc lint + arc unit