Details

Reviewers

fsu
mckusick
kib

Commits

rS346932: Optimize lseek(SEEK_DATA) on UFS.
rS345244: Optimize lseek(SEEK_DATA) on UFS.

Summary

(ufs|ext2)_getlbns() will return the logical block numbers of indirect
blocks needed to address a block.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23122
Build 22175: arc lint + arc unit

Event Timeline

markj created this revision.Mar 15 2019, 4:38 PM

Harbormaster completed remote builds in B23113: Diff 55111.Mar 15 2019, 4:38 PM

markj added reviewers: fsu, mckusick, kib.Mar 15 2019, 4:39 PM

kib added inline comments.Mar 15 2019, 5:41 PM

sys/ufs/ufs/ufs_bmap.c
104	Can you replace it by description what the function returns, de-facto ?

Readd a comment explaining the return value.

Harbormaster completed remote builds in B23118: Diff 55117.Mar 15 2019, 6:02 PM

markj marked an inline comment as done.Mar 15 2019, 6:02 PM

kib added inline comments.Mar 15 2019, 6:34 PM

sys/ufs/ufs/ufs_bmap.c
101–106	to a physical block number,
102	nbp must be provided when mapping extattr block, and is the buffer for that block. runb and runp, if provided, store the contiguous block runs before and after the *bnp block.

Describe nbp, runb and runp parameters per kib's suggestion.

Harbormaster completed remote builds in B23122: Diff 55122.Mar 15 2019, 9:23 PM

kib accepted this revision.Mar 15 2019, 9:25 PM

This revision is now accepted and ready to land.Mar 15 2019, 9:25 PM

I would preface the actual condition "The nbp parameter is non-NULL when the mapping is for a block that contains data, one of an external data block, a direct block, or the final block in a chain of indirect blocks." before the correct clarification "If mapping an extended attribute block, nbp must point to a buffer for that block."

Update based on Kirk's comment.

This revision now requires review to proceed.Mar 17 2019, 5:03 PM

Harbormaster completed remote builds in B23144: Diff 55168.Mar 17 2019, 5:03 PM

In D19598#419790, @mckusick wrote:

I would preface the actual condition "The nbp parameter is non-NULL when the mapping is for a block that contains data, one of an external data block, a direct block, or the final block in a chain of indirect blocks." before the correct clarification "If mapping an extended attribute block, nbp must point to a buffer for that block."

@kib pointed out that this doesn't make much sense given that nbp is only actually used when mapping an extended attribute block. In practice, ufs_strategy() will specify the buffer when reading data blocks, but it doesn't have to. Is this what you were referring to?

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2019, 5:34 PM

Closed by commit rS345244: Optimize lseek(SEEK_DATA) on UFS. (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2019, 5:34 PM

markj reopened this revision.Mar 17 2019, 5:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 29 2019, 10:05 PM

Closed by commit rS346932: Optimize lseek(SEEK_DATA) on UFS. (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.