Page MenuHomeFreeBSD

Remove incorrect comments.
ClosedPublic

Authored by markj on Mar 15 2019, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 2:45 AM
Unknown Object (File)
Sun, Jun 23, 8:19 AM
Unknown Object (File)
Fri, Jun 21, 11:04 AM
Unknown Object (File)
Tue, Jun 4, 8:45 PM
Unknown Object (File)
Apr 18 2024, 1:12 AM
Unknown Object (File)
Apr 18 2024, 12:37 AM
Unknown Object (File)
Apr 17 2024, 8:30 PM
Unknown Object (File)
Apr 17 2024, 8:16 PM
Subscribers

Details

Summary

(ufs|ext2)_getlbns() will return the logical block numbers of indirect
blocks needed to address a block.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23122
Build 22175: arc lint + arc unit

Event Timeline

sys/ufs/ufs/ufs_bmap.c
104

Can you replace it by description what the function returns, de-facto ?

  • Readd a comment explaining the return value.
sys/ufs/ufs/ufs_bmap.c
101–106

to a physical block number,

102

nbp must be provided when mapping extattr block, and is the buffer for that block.
runb and runp, if provided, store the contiguous block runs before and after the *bnp block.

  • Describe nbp, runb and runp parameters per kib's suggestion.
This revision is now accepted and ready to land.Mar 15 2019, 9:25 PM

I would preface the actual condition "The nbp parameter is non-NULL when the mapping is for a block that contains data, one of an external data block, a direct block, or the final block in a chain of indirect blocks." before the correct clarification "If mapping an extended attribute block, nbp must point to a buffer for that block."

  • Update based on Kirk's comment.
This revision now requires review to proceed.Mar 17 2019, 5:03 PM

I would preface the actual condition "The nbp parameter is non-NULL when the mapping is for a block that contains data, one of an external data block, a direct block, or the final block in a chain of indirect blocks." before the correct clarification "If mapping an extended attribute block, nbp must point to a buffer for that block."

@kib pointed out that this doesn't make much sense given that nbp is only actually used when mapping an extended attribute block. In practice, ufs_strategy() will specify the buffer when reading data blocks, but it doesn't have to. Is this what you were referring to?

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2019, 5:34 PM
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 29 2019, 10:05 PM
This revision was automatically updated to reflect the committed changes.