Page MenuHomeFreeBSD
Differential D19530

Followup to PR231977: Mention that /etc/pf.conf must be created first
ClosedPublic
Actions

Authored by bcr on Mar 10 2019, 4:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 4:15 PM
Unknown Object (File)
Mon, Mar 17, 2:00 AM
Unknown Object (File)
Fri, Mar 14, 12:53 PM
Unknown Object (File)
Sat, Mar 1, 4:26 PM
Unknown Object (File)
Jan 18 2025, 1:18 AM
Unknown Object (File)
Jan 17 2025, 2:47 PM
Unknown Object (File)
Jan 16 2025, 5:08 AM
Unknown Object (File)
Jan 14 2025, 7:05 AM
View All 71 Files
Subscribers
0mp
imp

Details

Reviewers
kp
koobs
Group Reviewers
manpages
Commits
rS345404: MFC r345080:
rS345080: Extend descriptions and comments about the need to create /etc/pf.conf.
Summary

This is a followup change to address PR 231977: we need to mention that /etc/pf.conf does not exist by default.

I'm having a bit of trouble coming up with a proper change/wording in /head/libexec/rc/rc.conf. Removing the line

pf_rules="/etc/pf.conf"         # rules definition file for pf

would be wrong, as it still is the default location for the file, even if it does not exist there by default. What would be a good way to say that in the comment? Something like

pf_rules="/etc/pf.conf"         # rules definition file for pf (nonexistent by default)

maybe?

Test Plan
  1. Apply the patch to share/man/man5/pf.conf.5
  2. See how it looks like: man ./share/man/man5/pf.conf.5

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcr created this revision.Mar 10 2019, 4:50 PM
Herald added a reviewer: manpages. · View Herald TranscriptMar 10 2019, 4:50 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B22988: Diff 54897.Mar 10 2019, 4:50 PM
0mp added a subscriber: 0mp.Mar 10 2019, 7:29 PM

pf_rules="/etc/pf.conf" # rules definition file for pf (nonexistent by default)

seems fine.

share/man/man5/pf.conf.5
3056 ↗(On Diff #54897)

How about The file has to be created manually as it is not installed with a standard installation.

bcr updated this revision to Diff 54904.Mar 10 2019, 7:50 PM

Update pf.conf.5 with suggestions from @0mp.

Harbormaster completed remote builds in B22993: Diff 54904.Mar 10 2019, 7:50 PM
kp accepted this revision.Mar 12 2019, 10:07 AM
This revision is now accepted and ready to land.Mar 12 2019, 10:07 AM
Closed by commit rS345080: Extend descriptions and comments about the need to create /etc/pf.conf. (authored by bcr). · Explain WhyMar 12 2019, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
libexec/
rc/
3 lines
share/
man/
man5/
4 lines

Diff 54999

View Options

head/libexec/rc/rc.conf

Context not available.
.PATH: ${SRCTOP}/sys/netpfil/pf .PATH: ${SRCTOP}/sys/netpfil/pf
PF= pf.h \ PF= pf.h \
pf_altq.h \ pf_altq.h \
pf_mtag.h pf_mtag.h \
pf_nl.h
PFPACKAGE= pf PFPACKAGE= pf
PFDIR= ${INCLUDEDIR}/netpfil/pf PFDIR= ${INCLUDEDIR}/netpfil/pf
Context not available.
View Options

head/share/man/man5/pf.conf.5

Context not available.
.PATH: ${SRCTOP}/sys/netpfil/pf .PATH: ${SRCTOP}/sys/netpfil/pf
PF= pf.h \ PF= pf.h \
pf_altq.h \ pf_altq.h \
pf_mtag.h pf_mtag.h \
pf_nl.h
PFPACKAGE= pf PFPACKAGE= pf
PFDIR= ${INCLUDEDIR}/netpfil/pf PFDIR= ${INCLUDEDIR}/netpfil/pf
Context not available.