Page MenuHomeFreeBSD
Differential D19418

Fix compilation WITHOUT_{INET,INET6}_SUPPORT or both.
ClosedPublic
Actions

Authored by bz on Mar 1 2019, 2:30 PM.
Tags
None
Referenced Files
F103127835: D19418.diff
Thu, Nov 21, 9:12 AM
Unknown Object (File)
Wed, Nov 20, 12:30 AM
Unknown Object (File)
Tue, Nov 19, 4:59 AM
Unknown Object (File)
Fri, Oct 25, 9:50 AM
Unknown Object (File)
Fri, Oct 25, 9:48 AM
Unknown Object (File)
Fri, Oct 25, 9:48 AM
Unknown Object (File)
Wed, Oct 23, 2:29 PM
Unknown Object (File)
Tue, Oct 22, 4:11 PM
View All Files
Subscribers
editor_callfortesting.org
imp
rgrimes
network

Details

Reviewers
ngie
hrs
ume
Commits
rS344740: Fix compilation of world with WITHOUT_{INET,INET6}_SUPPORT or both set.
Summary

buildworld failed when both WITHOUT_INET6_SUPPORT and INET
equivalent were set. Fix netstat and syslogd to make world
compile again.

Test Plan

amd64 buildworlds with one and both options set done.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 22827
Build 21915: arc lint + arc unit

Event Timeline

bz created this revision.Mar 1 2019, 2:30 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 1 2019, 2:30 PM
Harbormaster completed remote builds in B22827: Diff 54579.Mar 1 2019, 2:30 PM
rgrimes added a subscriber: rgrimes.Mar 1 2019, 3:14 PM
ngie accepted this revision.Mar 1 2019, 7:22 PM

Mmmm... I love ifdef soup.

This revision is now accepted and ready to land.Mar 1 2019, 7:22 PM
editor_callfortesting.org added a subscriber: editor_callfortesting.org.EditedMar 1 2019, 11:38 PM

Thank you bz@!

This clearly obsoletes part of my review where I conflated a few and I have work to do: https://reviews.freebsd.org/D17040

Are you planning to MFC this?

bz added a comment.Mar 1 2019, 11:44 PM
In D19418#415948, @editor_callfortesting.org wrote:

This clearly obsoletes part of my review where I conflated a few and I have work to do: https://reviews.freebsd.org/D17040

Oh I forgot about this one. We should sort the remaining parts of yours out as well.

Are you planning to MFC this?

I guess I will eventually at least to 12.

ume accepted this revision.Mar 3 2019, 2:48 AM

It looks good to me.

hrs accepted this revision.Mar 3 2019, 3:13 AM
Closed by commit rS344740: Fix compilation of world with WITHOUT_{INET,INET6}_SUPPORT or both set. (authored by bz). · Explain WhyMar 3 2019, 10:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
netstat/
29 lines
usr.sbin/
syslogd/
8 lines

Diff 54579

View Options

usr.bin/netstat/inet.c

Loading...
View Options

usr.sbin/syslogd/syslogd.c

Loading...