Update GDB to handle 0x93 (DW_OP_piece) instead of emitting errors.
ClosedPublic
Actions

Authored by sbruno on May 13 2015, 2:53 PM.

Details

Reviewers

emaste
davide
jhb

Commits

rS283029: Update intree gdb/kgdb to handle 2 dwarf types:

Summary

Sync from gdb commits https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;f=gdb/dwarf2loc.c;h=23572ecadc89af384c1804ad7692f32c55fbfc80 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=42be36b328ae784ae6981da7c7cab95b67ed7737 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=87808bd699575a850139a1f916512ab7a47fd496;hp=8d2c00cb73ae9b3d1e5d7317241dc02e575b7f1b

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sbruno updated this revision to Diff 5363.May 13 2015, 2:53 PM

sbruno retitled this revision from to Update GDB to handle 0x93 (DW_OP_piece) instead of emitting errors..

sbruno updated this object.

sbruno edited the test plan for this revision. (Show Details)

sbruno added reviewers: emaste, davide, jhb.

sbruno added a subscriber: peter.

Herald added a subscriber: imp. · View Herald TranscriptMay 13 2015, 2:53 PM

For reference the switch to GPLv3 happened here:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;f=gdb/dwarf2loc.c;h=ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd

commit ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd
Author: Nick Clifton <nickc@redhat.com>
Date:   Tue Jul 3 11:01:12 2007 +0000

    Switch to GPLv3

In D2534#46786, @emaste wrote:
For reference the switch to GPLv3 happened here:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;f=gdb/dwarf2loc.c;h=ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd
commit ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd
Author: Nick Clifton <nickc@redhat.com>
Date:   Tue Jul 3 11:01:12 2007 +0000

    Switch to GPLv3

The newest commit is from "Fri, 18 May 2007 19:42:42 +0000 (19:42 +0000)"

LGTM. Feel free to ship (maybe John wants to comment further as he's been touching gdb recently)

This revision is now accepted and ready to land.May 13 2015, 3:54 PM

Can't comment on license issues and related tho.

Yep, this is fine with me as well. The old gdb 6.1.1 in base has a limited life expectancy, but I have no problem bringing in pre-GPLv3 patches while it remains.