Differential D19040

Don't set IFCAP_TXRTLMT during lagg_clone_create().
ClosedPublic
Actions

Authored by jhb on Jan 30 2019, 9:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 18, 9:05 AM

	Unknown Object (File)
	Tue, Nov 18, 5:50 AM

	Unknown Object (File)
	Mon, Nov 17, 11:52 PM

	Unknown Object (File)
	Mon, Nov 17, 6:50 PM

	Unknown Object (File)
	Oct 19 2025, 12:51 AM

	Unknown Object (File)
	Oct 16 2025, 6:14 PM

	Unknown Object (File)
	Oct 16 2025, 7:52 AM

	Unknown Object (File)
	Oct 16 2025, 7:52 AM

View All Files

Subscribers

imp

Details

Reviewers

np
• hselasky
gallatin

Commits

rS343620: Don't set IFCAP_TXRTLMT during lagg_clone_create().

Summary

lagg_capabilities() will set the capability once interfaces supporting
the feature are added to the lagg. Setting it on a lagg without any
interfaces is pointless as the if_snd_tag_alloc call will always fail
in that case.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22284
Build 21479: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 30 2019, 9:36 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJan 30 2019, 9:36 PM

Harbormaster completed remote builds in B22284: Diff 53446.Jan 30 2019, 9:36 PM

Looks good.

This revision is now accepted and ready to land.Jan 30 2019, 9:39 PM

gallatin accepted this revision.Jan 31 2019, 12:15 AM

Closed by commit rS343620: Don't set IFCAP_TXRTLMT during lagg_clone_create(). (authored by jhb). · Explain WhyJan 31 2019, 9:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_lagg.c

4 lines

Diff 53446

View Options

Don't set IFCAP_TXRTLMT during lagg_clone_create().ClosedPublicActions