Page MenuHomeFreeBSD

Replace strlen with strnlen.
AbandonedPublic

Authored by araujo on Jan 29 2019, 12:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 5:24 PM
Unknown Object (File)
Feb 14 2024, 1:50 PM
Unknown Object (File)
Jan 31 2024, 1:12 AM
Unknown Object (File)
Dec 26 2023, 3:41 PM
Unknown Object (File)
Dec 20 2023, 12:48 AM
Unknown Object (File)
Dec 10 2023, 4:49 AM
Unknown Object (File)
Nov 3 2023, 3:37 PM
Unknown Object (File)
Nov 2 2023, 5:20 AM

Details

Reviewers
rgrimes
Group Reviewers
bhyve
Summary

These are most cosmetic changes.

Obtained from: Intel.

Test Plan

With guests:

  • Windows Server.
  • Linux Fedora.
  • FreeBSD HEAD.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22245
Build 21448: arc lint + arc unit

Event Timeline

usr.sbin/bhyve/bhyverun.c
236

While using strlnlen() here will guard against the insane notion that progname could be longer than PATH_MAX, it won't prevent fprintf from outputting an insane number of characters for progname should it be an unbounded string.

usr.sbin/bhyve/pci_virtio_net.c
891

there's no way that nstr won't be terminated in the first 80 characters because the snprintf 3 lines above guarantees it. so strnlen() is kinda useless here.

Revert strnlen to strlen on pci_virtio_net as snprintf does the job already.

usr.sbin/bhyve/bhyverun.c
236

@imp do you have any suggestion for the fprintf case?

It is basically a cosmetic change, so I have committed it already: r343634.

cem added inline comments.
usr.sbin/bhyve/bhyverun.c
236

@araujo the format string "%.*s" can be used to bound the length of string printed. Similar to the "%*s" padding entries that follow, two arguments are passed to printf for this format: int length, and (const) char * string. Only the first length bytes are formatted.

That said, I don't think strnlen() is useful here, so the simpler thing to do is just leave it alone.