Page MenuHomeFreeBSD
Differential D18779

Don't set if_linkmib for vlan(4).
ClosedPublic
Actions

Authored by markj on Jan 8 2019, 1:13 AM.
Tags
None
Referenced Files
F152649551: D18779.diff
Thu, Apr 16, 6:45 AM
Unknown Object (File)
Sun, Apr 12, 11:09 AM
Unknown Object (File)
Fri, Apr 10, 4:06 PM
Unknown Object (File)
Fri, Apr 10, 10:54 AM
Unknown Object (File)
Tue, Apr 7, 6:21 AM
Unknown Object (File)
Sun, Apr 5, 9:13 PM
Unknown Object (File)
Fri, Apr 3, 11:51 AM
Unknown Object (File)
Tue, Mar 31, 9:19 AM
View All Files
Subscribers
ae
imp
kp

Details

Reviewers
kp
Group Reviewers
network
Commits
rS342887: Stop setting if_linkmib in vlan(4) ifnets.
Summary

It doesn't really make sense:

  • the structure being exported isn't a MIB,
  • the structure being exported is private to the kernel and always has been, and
  • no other drivers in widespread use implement a link-specific MIB.

Moreover, the IFDATA_LINKSPECIFIC interface allows a privileged user to
overwrite a bunch of internal state without any validation.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21886
Build 21132: arc lint + arc unit

Event Timeline

markj created this revision.Jan 8 2019, 1:13 AM
Herald added a subscriber: ae. · View Herald TranscriptJan 8 2019, 1:13 AM
Harbormaster completed remote builds in B21877: Diff 52655.Jan 8 2019, 1:13 AM
markj added a reviewer: network.Jan 8 2019, 1:13 AM
kp accepted this revision as: kp.Jan 8 2019, 8:14 AM
kp added a subscriber: kp.

LGTM.

This revision is now accepted and ready to land.Jan 8 2019, 8:14 AM
markj updated this revision to Diff 52672.Jan 8 2019, 5:02 PM
  • Also collapse ifv_linkmib into the parent structure.
This revision now requires review to proceed.Jan 8 2019, 5:02 PM
Harbormaster completed remote builds in B21886: Diff 52672.Jan 8 2019, 5:02 PM
Harbormaster completed remote builds in B21886: Diff 52672.
This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2019, 4:47 PM
Closed by commit rS342887: Stop setting if_linkmib in vlan(4) ifnets. (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJan 9 2019, 4:47 PM

Revision Contents
Changeset List

PathSize
sys/
net/
29 lines

Diff 52672

View Options

sys/net/if_vlan.c

Loading...