Page MenuHomeFreeBSD
Differential D18644

Update my committer name and add my new mentor relationship
ClosedPublic
Actions

Authored by ngie on Dec 24 2018, 12:26 AM.
Tags
None
Referenced Files
F152998589: D18644.id52278.diff
Sat, Apr 18, 1:31 PM
F152973555: D18644.id52272.diff
Sat, Apr 18, 10:27 AM
Unknown Object (File)
Thu, Apr 16, 8:34 AM
Unknown Object (File)
Thu, Apr 16, 12:25 AM
Unknown Object (File)
Sat, Apr 11, 10:04 AM
Unknown Object (File)
Sat, Apr 11, 1:09 AM
Unknown Object (File)
Wed, Apr 8, 10:17 PM
Unknown Object (File)
Wed, Apr 8, 6:12 AM
View All Files
Subscribers
emaste
imp
jmmv
jtl
rpaulo

Details

Reviewers
emaste
jhb
jtl
Commits
rS342920: Update my committer name and add my new mentor relationship
Summary

@emaste and @jtl graciously accepted my request to mentor me this time around with my src commits while I get up to speed.

Thank you very much @jmmv and @rpaulo for the help with my previous mentorship!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21703
Build 20987: arc lint + arc unit

Event Timeline

ngie created this revision.Dec 24 2018, 12:26 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 24 2018, 12:26 AM
Harbormaster completed remote builds in B21703: Diff 52272.Dec 24 2018, 12:26 AM
emaste added a comment.Dec 24 2018, 3:21 AM

I suspect we should leave the original entries in to record the historical relationship

ngie retitled this revision from Update my committer name and mentor/mentee relationships to Update my committer name and add my new mentor relationship.Dec 24 2018, 3:58 AM
ngie edited the summary of this revision. (Show Details)
ngie edited the test plan for this revision. (Show Details)
ngie updated this revision to Diff 52278.Dec 24 2018, 3:59 AM

Keep my previous maintainer relationship intact, per @emaste's request.

Harbormaster completed remote builds in B21708: Diff 52278.Dec 24 2018, 3:59 AM
ngie added a comment.Dec 24 2018, 4:00 AM
In D18644#397666, @emaste wrote:

I suspect we should leave the original entries in to record the historical relationship

Ah, yes... I was mixing this up with the file under svnadmin, I suspect.

ngie added a comment.Jan 10 2019, 1:02 AM

@emaste, @jtl: ping?

emaste accepted this revision.Jan 10 2019, 3:18 PM

Approved by: emaste (mentor)

This revision is now accepted and ready to land.Jan 10 2019, 3:18 PM
Closed by commit rS342920: Update my committer name and add my new mentor relationship (authored by ngie). · Explain WhyJan 10 2019, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
share/
misc/
7 lines

Diff 52272

View Options

share/misc/committers-src.dot

Loading...