Page MenuHomeFreeBSD
Differential D18608

iscsictl.8: Add missing flag parameters
ClosedPublic
Actions

Authored by 0mp on Dec 19 2018, 12:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 11:28 PM
Unknown Object (File)
Sun, Sep 6, 6:00 AM
Unknown Object (File)
Sun, Sep 6, 5:09 AM
Unknown Object (File)
Sat, Sep 5, 3:17 PM
Unknown Object (File)
Sat, Sep 5, 1:31 PM
Unknown Object (File)
Thu, Sep 3, 12:01 PM
Unknown Object (File)
Thu, Sep 3, 8:30 AM
Unknown Object (File)
Wed, Sep 2, 5:46 PM
View All Files
Subscribers
imp

Details

Reviewers
trasz
bcr
eadler
Group Reviewers
manpages
docs
Commits
rS342553: iscsictl.8: Add missing flag parameters
Summary

Changes:

  • Add missing parameters to flags in the description of available options.
  • Remove spaces between alternative parameters and "|".
  • Align descriptions of options to the longest option.
  • Use em dash instead of a hyphen.
Test Plan

portlint

igor

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21642
Build 20934: arc lint + arc unit

Event Timeline

0mp created this revision.Dec 19 2018, 12:37 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 19 2018, 12:37 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B21642: Diff 52161.Dec 19 2018, 12:37 PM
0mp edited the summary of this revision. (Show Details)Dec 19 2018, 12:38 PM
0mp added a reviewer: docs.Dec 19 2018, 2:24 PM
bcr accepted this revision.Dec 19 2018, 2:49 PM

OK from the manpage side of things. @trasz has to give the go for the content part.

This revision is now accepted and ready to land.Dec 19 2018, 2:49 PM
0mp added a comment.Dec 27 2018, 12:38 PM
In D18608#396787, @bcr wrote:

OK from the manpage side of things. @trasz has to give the go for the content part.

Actually, there are no content changes.

bcr requested changes to this revision.Dec 27 2018, 2:37 PM
This comment was removed by bcr.
This revision now requires changes to proceed.Dec 27 2018, 2:37 PM
bcr accepted this revision.Dec 27 2018, 2:37 PM

Oops, selected the wrong option. I was meant to select the "Approve" option, so go ahead with the commit.

This revision is now accepted and ready to land.Dec 27 2018, 2:37 PM
Closed by commit rS342553: iscsictl.8: Add missing flag parameters (authored by 0mp). · Explain WhyDec 27 2018, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
iscsictl/
36 lines

Diff 52161

View Options

usr.bin/iscsictl/iscsictl.8

Loading...