Page MenuHomeFreeBSD
Differential D18602

Add -i ("insecure") option to daemon(8) to create readable pid files.
AcceptedPublic
Actions

Authored by marck on Dec 18 2018, 8:41 PM.
Tags
None
Referenced Files
F82844114: D18602.id52150.diff
Fri, May 3, 2:58 AM
F82843897: D18602.id.diff
Fri, May 3, 2:54 AM
F82826774: D18602.diff
Thu, May 2, 10:33 PM
Unknown Object (File)
Tue, Apr 30, 6:37 PM
Unknown Object (File)
Feb 22 2024, 3:02 PM
Unknown Object (File)
Jan 12 2024, 5:56 AM
Unknown Object (File)
Jan 12 2024, 5:05 AM
Unknown Object (File)
Dec 20 2023, 3:36 AM
View All 13 Files
Subscribers
0mp
bcr
imp
jilles
Contributor Reviews (src)

Details

Reviewers
bcr
0mp
Group Reviewers
manpages
Summary

For monitoring reasong there is usually no sense to run it from root.
However, daemon(8) creates pid files unconditionally with 0600 mode.
This patch adds -i option to override this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21633
Build 20926: arc lint + arc unit

Event Timeline

marck created this revision.Dec 18 2018, 8:41 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 18 2018, 8:41 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
Harbormaster completed remote builds in B21633: Diff 52150.Dec 18 2018, 8:41 PM
jilles added a subscriber: jilles.Dec 18 2018, 8:53 PM

A world-readable pidfile can be locked in shared mode by any user, which may cause the real daemon to act as if it is already running when it is not (e.g. after it crashed).

Ideally, something better than pidfiles would be used to track and monitor daemons.

bcr accepted this revision.Dec 30 2018, 12:26 PM
bcr added a subscriber: bcr.

OK from the manpage side, a src comitter should check the implementation part for correctness.

This revision is now accepted and ready to land.Dec 30 2018, 12:26 PM
0mp accepted this revision.Jan 2 2019, 10:02 AM
0mp added a subscriber: 0mp.

Please remeber to bump the date in the manual page.

usr.sbin/daemon/daemon.8
67

It looks like we refer to PID files as pidfiles later in the manual. We might want to stick to pidfiles for consistency.

Revision Contents
Changeset List

PathSize
usr.sbin/
daemon/
4 lines
19 lines

Diff 52150

View Options

usr.sbin/daemon/daemon.8

Loading...
View Options

usr.sbin/daemon/daemon.c

Loading...