Normalize COMPAT_43 syscall declarations.
ClosedPublic
Actions

Authored by brooks on Jun 15 2018, 12:11 AM.

Details

Reviewers

emaste
kib
jhb

Commits

rS341495: Remove NOARGS from oaccept.
rS341474: Normalize COMPAT_43 syscall declarations.

Summary

Have ogetkerninfo, ogetpagesize, ogethostname, osethostname, and oaccept
declare o<foo>_args structs rather than non-compat ones. Due to a
failure to use NOARGS in most cases this adds only one new declaration.

No changes required in freebsd32 as only ogetpagesize() is implemented and it
has a 32-bit specific implementation.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21353
Build 20680: arc lint + arc unit

Event Timeline

brooks created this revision.Jun 15 2018, 12:11 AM

Harbormaster completed remote builds in B17289: Diff 43792.Jun 15 2018, 12:11 AM

Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.

Does freebsd32 need same treatment ?

In D15816#334486, @kib wrote:

Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.

I like them as local documentation so will leave then undisturbed other than the rename where they match local style and members are used.

Does freebsd32 need same treatment ?

No, because it fails to implement all but getpagesize and that has an ofreebsd32_getpagesize() that returns IA32_PAGE_SIZE. The unimplemented cases are probably a bug, but it's not clear they matter even for aout binaries (4.4lite had already implemented all but accept() as userspace wrappers around sysctl()).

brooks edited the summary of this revision. (Show Details)Jun 18 2018, 4:54 PM

brooks added a reviewer: jhb.Oct 4 2018, 9:23 PM