Page MenuHomeFreeBSD

Normalize COMPAT_43 syscall declarations.
ClosedPublic

Authored by brooks on Jun 15 2018, 12:11 AM.

Details

Summary

Have ogetkerninfo, ogetpagesize, ogethostname, osethostname, and oaccept
declare o<foo>_args structs rather than non-compat ones. Due to a
failure to use NOARGS in most cases this adds only one new declaration.

No changes required in freebsd32 as only ogetpagesize() is implemented and it
has a 32-bit specific implementation.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 17289
Build 17126: arc lint + arc unit

Event Timeline

Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.

Does freebsd32 need same treatment ?

In D15816#334486, @kib wrote:

Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.

I like them as local documentation so will leave then undisturbed other than the rename where they match local style and members are used.

Does freebsd32 need same treatment ?

No, because it fails to implement all but getpagesize and that has an ofreebsd32_getpagesize() that returns IA32_PAGE_SIZE. The unimplemented cases are probably a bug, but it's not clear they matter even for aout binaries (4.4lite had already implemented all but accept() as userspace wrappers around sysctl()).

  • Rebase
  • GC duplicate, documentary definitions of _args structs.

declErations, both it the title and in the text.

This revision is now accepted and ready to land.Dec 4 2018, 9:06 AM
brooks retitled this revision from Normalize COMPAT_43 syscall declerations. to Normalize COMPAT_43 syscall declarations..Dec 4 2018, 4:30 PM
brooks edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.