Page MenuHomeFreeBSD
Differential D17426

Speed up devel/gdb startup on FreeBSD
ClosedPublic
Actions

Authored by jhb on Oct 5 2018, 12:06 AM.
Tags
None
Referenced Files
F104181182: D17426.id51671.diff
Wed, Dec 4, 11:07 AM
Unknown Object (File)
Mon, Nov 25, 5:13 PM
Unknown Object (File)
Fri, Nov 22, 1:18 PM
Unknown Object (File)
Thu, Nov 21, 2:21 PM
Unknown Object (File)
Wed, Nov 6, 8:51 PM
Unknown Object (File)
Tue, Nov 5, 10:12 PM
Unknown Object (File)
Tue, Nov 5, 10:12 PM
Unknown Object (File)
Tue, Nov 5, 10:12 PM
View All Files
Subscribers
emaste
kbowling
mat
pizzamig

Details

Reviewers
mmacy
jmd
luca.pizzamiglio_gmail.com
pizzamig
bdragon
Commits
rP486773: Speed up devel/gdb startup on FreeBSD
Summary

On non-Linux systems that do not have fdwalk(), gdb currently iterates over all possible file descriptors when checking for open files.
Fix this by adding a FreeBSD implementation using kinfo_getfile().

Fixes extremely long startup times on ppc64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21285
Build 20620: arc lint + arc unit

Event Timeline

bdragon created this revision.Oct 5 2018, 12:06 AM
Herald added subscribers: mat, emaste. · View Herald TranscriptOct 5 2018, 12:06 AM
Harbormaster completed remote builds in B19991: Diff 48762.Oct 5 2018, 12:06 AM
mmacy added reviewers: jhb, jmd.Oct 5 2018, 12:25 AM
kbowling added a subscriber: kbowling.Oct 9 2018, 7:24 AM
linimon retitled this revision from Speed up gdb startup on FreeBSD to Speed up devel/gdb startup on FreeBSD.Oct 9 2018, 3:22 PM
jhb added a comment.Nov 30 2018, 11:22 PM

I've merged a similar change upstream to gdb in commit 93579f6f90. We can pull that into the port as a commit-<foo> patch.

jhb updated this revision to Diff 51452.Nov 30 2018, 11:25 PM
  • Use patch from upstream commit.
  • Bump PORTREVISION.
jhb added a reviewer: luca.pizzamiglio_gmail.com.Nov 30 2018, 11:25 PM
Harbormaster completed remote builds in B21285: Diff 51452.Nov 30 2018, 11:25 PM
pizzamig requested changes to this revision.Dec 5 2018, 1:13 PM
pizzamig added a subscriber: pizzamig.

Patch doesn't apply cleanly.

devel/gdb/files/commit-93579f6f90
16

This section of the patch fails, because the ChangeLog in the release is missing the latest changes.
I'd remove the Changelog diff from the patch

This revision now requires changes to proceed.Dec 5 2018, 1:13 PM
jhb updated this revision to Diff 51623.Dec 5 2018, 6:48 PM

Drop ChangeLog diff.

Harbormaster completed remote builds in B21375: Diff 51623.Dec 5 2018, 6:48 PM
jhb commandeered this revision.Dec 5 2018, 6:49 PM
jhb edited reviewers, added: bdragon; removed: jhb.
jhb added inline comments.
devel/gdb/files/commit-93579f6f90
16

Oops, yes, I normally do that for 'commit-*' files and just missed this one.

jhb marked 2 inline comments as done.Dec 5 2018, 6:49 PM
pizzamig accepted this revision.Dec 6 2018, 4:53 PM

look good to me

This revision is now accepted and ready to land.Dec 6 2018, 4:53 PM
Closed by commit rP486773: Speed up devel/gdb startup on FreeBSD (authored by jhb). · Explain WhyDec 6 2018, 5:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
gdb/
4 lines
files/
70 lines

Diff 51452

View Options

devel/gdb/Makefile

Loading...
View Options

devel/gdb/files/commit-93579f6f90

Loading...