Fix newvers.sh with BUILD_WITH_STRICT_TMPPATH=1
ClosedPublic
Actions

Authored by arichardson on Nov 29 2018, 10:34 AM.

Details

Reviewers

emaste
markj

Commits

rS341514: Fix newvers.sh with BUILD_WITH_STRICT_TMPPATH=1

Summary

newvers.sh runs mkfifo which did not exist before this change.
However, I didn't notice before because it is run from a function
where a missing command does cause a noticeable failure.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21258
Build 20599: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 29 2018, 10:34 AM

Harbormaster completed remote builds in B21258: Diff 51348.Nov 29 2018, 10:36 AM

LGTM. One of either @kib or @markj suggested eliminating the mkfifo but I believe we cannot without a more capable shell.

This revision is now accepted and ready to land.Nov 29 2018, 3:19 PM

Oh huh. What's the problem with:

$git_cmd ... | while read smode ...; do
...
done

? A quick test suggests that /bin/sh does indeed support that.

Anyway, LGTM.

Oh, maybe I'm conflating a different comment with something about mkfifo, but it was in D15968. In any case, the issue is that with cmd | while ... a return in the while loop returns from the subshell, not the function. There's a decent Stack Overflow discussion at https://stackoverflow.com/questions/13726764/while-loop-subshell-dilemma-in-bash