Page MenuHomeFreeBSD
Differential D18042

devel/tortoisehg: Update to 4.8.
ClosedPublic
Actions

Authored by arrowd on Nov 19 2018, 10:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 3, 2:05 AM
Unknown Object (File)
Fri, Oct 2, 9:19 PM
Unknown Object (File)
Wed, Sep 30, 7:23 PM
Unknown Object (File)
Wed, Sep 30, 6:37 PM
Unknown Object (File)
Wed, Sep 30, 6:19 PM
Unknown Object (File)
Wed, Sep 30, 3:15 PM
Unknown Object (File)
Thu, Sep 24, 12:29 PM
Unknown Object (File)
Sat, Sep 19, 1:03 PM
View All Files
Subscribers
ndowens_yahoo.com

Details

Reviewers
tcberner
Group Reviewers
Contributor Reviewers (ports)
Commits
rP485649: devel/tortoisehg: Update to 4.8.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20908
Build 20274: arc lint + arc unit

Event Timeline

arrowd created this revision.Nov 19 2018, 10:56 AM
Harbormaster completed remote builds in B20889: Diff 50594.Nov 19 2018, 10:56 AM
ndowens_yahoo.com added a subscriber: ndowens_yahoo.com.Nov 20 2018, 4:39 AM
ndowens_yahoo.com added inline comments.
devel/tortoisehg/Makefile
17–18

Move OPTIONS block below NO_ARCH
Nothing should go be below OPTIONS block

19–20

Move/keep in OPTIONS block

20

Move this under USES or move INSTALLS_ICONS down one line below this one

tcberner added a comment.Nov 20 2018, 6:07 AM

You can find the documentation on it here: Order of Variables

INSTALLS_ICONS is likely even not needed, as this is not a gnome application.

arrowd updated this revision to Diff 50627.Nov 20 2018, 8:09 AM
  • Address comments.
Harbormaster completed remote builds in B20908: Diff 50627.Nov 20 2018, 8:09 AM
arrowd marked 3 inline comments as done.Nov 20 2018, 8:11 AM
tcberner accepted this revision.Nov 22 2018, 7:50 PM

Looks good to me.

This revision is now accepted and ready to land.Nov 22 2018, 7:50 PM
Closed by commit rP485649: devel/tortoisehg: Update to 4.8. (authored by arrowd). · Explain WhyNov 23 2018, 10:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
tortoisehg/
20 lines
6 lines
files/
8 lines
3 lines

Diff 50627

View Options

devel/tortoisehg/Makefile

Loading...
View Options

devel/tortoisehg/distinfo

Loading...
View Options

devel/tortoisehg/files/patch-tortoisehg_hgqt_qtlib.py

Loading...
View Options

devel/tortoisehg/pkg-plist

Loading...